Skip to content
This repository was archived by the owner on Apr 9, 2021. It is now read-only.

Run the gradle wrapper in examples root directory#789

Merged
carl-mastrangelo merged 1 commit intogrpc:masterfrom
dapengzhang0:patch-5
Dec 12, 2018
Merged

Run the gradle wrapper in examples root directory#789
carl-mastrangelo merged 1 commit intogrpc:masterfrom
dapengzhang0:patch-5

Conversation

@dapengzhang0
Copy link
Copy Markdown

The project gradle wrapper is about to be removed grpc/grpc-java#5141

The project gradle wrapper is about to be removed grpc/grpc-java#5141
@dapengzhang0
Copy link
Copy Markdown
Author

@ericgribkoff PTAL

@dapengzhang0
Copy link
Copy Markdown
Author

Thanks @ericgribkoff.
@jtattermusch, can you please approve/merge it?

@dapengzhang0
Copy link
Copy Markdown
Author

@carl-mastrangelo PTAL

Copy link
Copy Markdown

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try this out? There is no android/helloworld to run in.

Copy link
Copy Markdown

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-mastrangelo carl-mastrangelo merged commit 8aba788 into grpc:master Dec 12, 2018
@dapengzhang0 dapengzhang0 deleted the patch-5 branch February 8, 2019 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants