Skip to content
This repository was archived by the owner on Apr 9, 2021. It is now read-only.

Rename invalid date 18-18 to 12-18; use : for the :`#799

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
kkm000:patch-5
Dec 18, 2018
Merged

Rename invalid date 18-18 to 12-18; use : for the :`#799
jtattermusch merged 1 commit intogrpc:masterfrom
kkm000:patch-5

Conversation

@kkm000
Copy link
Copy Markdown

@kkm000 kkm000 commented Dec 18, 2018

Fix both, to be on the safe side.

@kkm000
Copy link
Copy Markdown
Author

kkm000 commented Dec 18, 2018

Now I understand what @carl-mastrangelo meant by "wonky"!!! :)

Copy link
Copy Markdown

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtattermusch jtattermusch merged commit fbd07fa into grpc:master Dec 18, 2018
@kkm000
Copy link
Copy Markdown
Author

kkm000 commented Dec 18, 2018

Magic!!! It worked :-)) Thanks!

@jtattermusch
Copy link
Copy Markdown

Things are looking good now: https://grpc.io/blog/ Thanks for taking the time to write the blogpost.

@kkm000
Copy link
Copy Markdown
Author

kkm000 commented Dec 18, 2018

Links are also ok, point to expected places, except that suddenly removed MS recommendation. Do not really know what to do with it. Maybe nothing--it's external. I can also point it to a pre-removal version on GitHub. What's your take on it? Leave as is or redirect?

@kkm000
Copy link
Copy Markdown
Author

kkm000 commented Dec 18, 2018

And thank you--took quite an effort on your part, too. Hope it would really help people out there.

If only packaging would be as simple for C++ too. Maybe restricting packaged libs to VC 2017 is a better option that nothing. We'll think about it! : ) I want to see if there would be an ABI change in VC 2019. I haven't played with it yet, we are also pushing a major release internally, had no time; also, 2019 is only in preview now, so things may change. But I'll follow it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants