Merged
Conversation
|
tomerv
force-pushed
the
L95-python-reflection-client
branch
from
de7058d to
ac8a040
Compare
Contributor
Author
|
How can I get @linux-foundation-easycla to re-check the commit? |
Contributor
|
/easycla |
lidizheng
approved these changes
Jan 20, 2022
Contributor
lidizheng
left a comment
lidizheng
left a comment
There was a problem hiding this comment.
This is a really nice tool to have for gRPC clients. LGTM.
But before merging the proposal, we might want to create the discussion thread, and wait 10 days (comment period).
Contributor
Author
|
/easycla |
Contributor
Author
|
Not sure what to do with the CLA, seems like it's stuck. Should I start a new pull request? |
Contributor
|
I think the check has passed. See the lower section of the GitHub UI. That comment just... stale. |
Contributor
Author
|
We passed the 10 days mark - is it approved? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.