Open
Conversation
siddharthnohria
changed the title
Vignesh2208
reviewed
Apr 2, 2026
| metadata, and an initial payload message. To the client application, this RPC | ||
| immediately returns a "Virtual Stub", which the application can then use to send | ||
| any virtual RPCs. | ||
|
|
There was a problem hiding this comment.
Please add an example here to demonstrate this
| all common application context has been successfully set up, and the server is | ||
| ready to accept virtual RPC traffic. Internally, this signal triggers sending | ||
| the `server_initial_metadata` from the server to the client. | ||
|
|
There was a problem hiding this comment.
Please add an example here to clarify how the server application is expected to provide an explicit signal to the server session handler
| channel_ = grpc:::CreateVirtualChannel(std::move(call)); | ||
| } | ||
|
|
||
| void ClientReactor::OnSessionAcknowledged(bool ok) override { |
Vignesh2208
reviewed
Apr 2, 2026
| virtual call's arena. | ||
|
|
||
| This design ensures that: | ||
|
|
There was a problem hiding this comment.
Please include an example of the proposed API changes to ServerContext
ananda1066
reviewed
Apr 2, 2026
|
|
||
| // In Virtual RPC Handler: Retrieve the shared application state from the session | ||
| auto app_context = context->GetSessionContext<ApplicationContext>(); | ||
| ``` |
Contributor
There was a problem hiding this comment.
API details LGTM but I do think we need to flesh out what telemetry looks like here as well so we have consistency across the stacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.