Skip to content

Added installation steps for Python 2.7 and go 1.10+#116

Merged
alanjds merged 4 commits intogrumpyhome:masterfrom
aaronjohnson92:master
Dec 27, 2019
Merged

Added installation steps for Python 2.7 and go 1.10+#116
alanjds merged 4 commits intogrumpyhome:masterfrom
aaronjohnson92:master

Conversation

@aaronjohnson92
Copy link
Copy Markdown

If you'd prefer this setup differently just let me know and I'll re-format to your specifications.

@alanjds
Copy link
Copy Markdown

alanjds commented Oct 24, 2018

Thanks for your effort, @aaronjohnson92.

Had you tried Grumpy on Windows? It is not being tested by the CI. I even doubt that it can build on non-POSIX platforms. Can you provide feedback on this?

About the text: I start to think that the README is already too big. Maybe just informing the pre-requisites and linking to external pages for instructions, or provide another file (PREREQUISITES ?) would be better. What do you think?

@aaronjohnson92
Copy link
Copy Markdown
Author

aaronjohnson92 commented Oct 24, 2018

I've updated the readme.md file to include links to the official installation documentation for the pre-requisites. I cut down more than half of what I submitted the first time. If you have any suggestions or preferences as to how it could be formatted I'm more than happy to change it to fit that!

Also, the longer section is the installation instructions for Python2.7 on linux. Only because some flavors don't bundle 2.7 anymore and default to 3.5+ which has the unfortunate consequence of the default python path being set to 3.5+ rather than 2.7 which could make the installation process some what confusing for newer users.

@alanjds alanjds merged commit 908ee90 into grumpyhome:master Dec 27, 2019
@alanjds
Copy link
Copy Markdown

alanjds commented Dec 27, 2019

Thanks @aaronjohnson92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants