Skip to content

fixes issue #67 - replace AssertionError with False and respective error string#144

Merged
alanjds merged 1 commit intogrumpyhome:masterfrom
srixivas:issue_67
Dec 27, 2019
Merged

fixes issue #67 - replace AssertionError with False and respective error string#144
alanjds merged 1 commit intogrumpyhome:masterfrom
srixivas:issue_67

Conversation

@srixivas
Copy link
Copy Markdown

@srixivas srixivas commented Oct 26, 2019

Fixes #67

Changes:

  • Remove AssertionError
  • Assert False and return the Exception string that should have occurred from the previous line

As of now made the changes only to list_test.py. Let me know if this is good or any more changes are required.

@alanjds alanjds merged commit 77b7bfb into grumpyhome:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

this is not working. because bool(AssertionError) is true

2 participants