fix(grunt/tui): TicketHoverCard text-rendering — clean preview lines, no character bleed#17
Merged
Merged
Conversation
… no character bleed Refs hivemind anomalyco#233. Closes Nik feedback after PR #16: 'there is some gibberish being added in to text' with a screenshot showing the title rendered as '##nNikrdirective...' (jumbled) and the scope as 'clicktto,open inrhivemind-ui closed the session before' (with extra letters and the footer-line text bleeding into the scope). ## Root cause Three compounding issues in the card body: 1. **Multi-line scope text with wrapMode='word'** — opentui's text renderable joins adjacent <text> siblings when wrap-word is enabled, producing character bleed across line boundaries. The actual title was correct in the api response; the renderer was conflating it with the scope's first line plus the footer ('click to open in hivemind-ui') text. 2. **Markdown chars in scope** — full scope text contains markdown ('## Nik directive 2026-05-26T23:01Z (recovered from ses_...)') which the plain-text renderable was passing through verbatim, then word-wrap ate the spaces around '#' and '##'. 3. **<>Fragment</> wrapping the inner content** — Fragments don't establish a layout box; the renderable was free to flow children in weird ways. The position-absolute outer box wasn't enough to constrain line breaks per-text. ## Fix - Wrap inner content in <box flexDirection='column'> so each <text> is one explicit line. - Drop wrapMode='word' from the body; let opentui's natural per-text layout handle line bounds. - Pre-flatten the scope: strip code fences, headings, emphasis markers, and collapse whitespace to single spaces. This makes the preview a proper one-paragraph blurb instead of attempting to render markdown inside a 60-col tooltip. - Compute title / meta / scope-preview as plain strings before render. - Drop the <b> wrapper around title (use attributes={1} on <text> instead, matching the pattern in routes/session/sidebar.tsx). ## Verified bun typecheck clean. Local install reports 1.15.10-grunt.7+local.f9cad9dea.dirty.
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
terrxo
added a commit
that referenced
this pull request
May 28, 2026
… no character bleed (#17) Refs hivemind anomalyco#233. Closes Nik feedback after PR #16: 'there is some gibberish being added in to text' with a screenshot showing the title rendered as '##nNikrdirective...' (jumbled) and the scope as 'clicktto,open inrhivemind-ui closed the session before' (with extra letters and the footer-line text bleeding into the scope). ## Root cause Three compounding issues in the card body: 1. **Multi-line scope text with wrapMode='word'** — opentui's text renderable joins adjacent <text> siblings when wrap-word is enabled, producing character bleed across line boundaries. The actual title was correct in the api response; the renderer was conflating it with the scope's first line plus the footer ('click to open in hivemind-ui') text. 2. **Markdown chars in scope** — full scope text contains markdown ('## Nik directive 2026-05-26T23:01Z (recovered from ses_...)') which the plain-text renderable was passing through verbatim, then word-wrap ate the spaces around '#' and '##'. 3. **<>Fragment</> wrapping the inner content** — Fragments don't establish a layout box; the renderable was free to flow children in weird ways. The position-absolute outer box wasn't enough to constrain line breaks per-text. ## Fix - Wrap inner content in <box flexDirection='column'> so each <text> is one explicit line. - Drop wrapMode='word' from the body; let opentui's natural per-text layout handle line bounds. - Pre-flatten the scope: strip code fences, headings, emphasis markers, and collapse whitespace to single spaces. This makes the preview a proper one-paragraph blurb instead of attempting to render markdown inside a 60-col tooltip. - Compute title / meta / scope-preview as plain strings before render. - Drop the <b> wrapper around title (use attributes={1} on <text> instead, matching the pattern in routes/session/sidebar.tsx). ## Verified bun typecheck clean. Local install reports 1.15.10-grunt.7+local.f9cad9dea.dirty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes hivemind anomalyco#233 (text rendering nit after PR #16 landed shadcn-style positioning).
Nik feedback
Screenshot showed title rendered as 'gibberish' — actual:
##nNikrdirectiveo2026-05-26T23:01Zd(recoveredafromrd on(correct source:## Nik directive 2026-05-26T23:01Z (recovered from ses_...)). Scope rendered with characters from the 'click to open in hivemind-ui' footer line bleeding INTO the scope text.Three causes compounding
wrapMode='word'on adjacent<text>siblings joins them across line boundaries in opentui — characters bleed between lines.## headingsyntax, blank-line gaps, emphasis markers. Plain-text renderable passed them through; word-wrap mangled the spaces around#glyphs.Fix
<box flexDirection='column'>(one explicit line per<text>)wrapMode='word'— natural per-text bounds work fine<b>...</b>withattributes={1}on the title<text>(matches existing sidebar.tsx pattern)Verified
bun typecheckclean. Local install reports1.15.10-grunt.7+local.f9cad9dea.dirty.