fix(opencode): compaction uses selected session model, not hardcoded sonnet#25
Merged
Conversation
…dcoded sonnet selectCompactionModel forced every non-anthropic session model through claude-sonnet-4-6 for summarization. That is wasteful and counterproductive for large-context drivers (e.g. a 1M-token model gets routed through sonnet). Tier 4 now returns the session model. The opt-in tiers (agent.model, compaction.model, compaction.model_overrides) are unchanged, so anyone who wants a dedicated compaction model — including sonnet — still gets it. Closes anomalyco#377
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes hivemind anomalyco#377.
selectCompactionModel()inpackages/opencode/src/session/compaction.tshad a tier-4 default that forced every non-Anthropic session model to compact viaclaude-sonnet-4-6. For a large-context driver (the motivating case: a deepseek 1M-context model) this is wasteful and counterproductive — you pay for a sonnet round-trip to summarize history the driver could compact itself.Change
Tier 4 now returns the session model. One-file change.
The opt-in tiers are untouched, so configurability is fully preserved:
agent.model(explicit compaction-agent override)compaction.model(provider/model, e.g.anthropic/claude-sonnet-4-6)compaction.model_overrides(glob-pattern, keyed on the session model)Anyone who wants sonnet-for-compaction (or Haiku, etc.) still gets it via tiers 1-3 — including a
model_overridesglob to scope it to specific drivers.Acceptance (anomalyco#377)
opencode.json/ active provider config by defaultVerification
bun typecheck— cleanbun test test/session/compaction.test.ts test/session/compaction-strip.test.ts— 59 pass / 0 failNotes
compaction.modelconfig knob + structured summary prompt) already landed ondev.