Skip to content

fix: set r = 1, update error label #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcw-grunt merged 2 commits into from
May 21, 2025
Merged

fix: set r = 1, update error label #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e9d5a
set r= 1
kcw-grunt May 21, 2025
2c3b718
Update the stuck transaction message
kcw-grunt May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BRPeer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,10 +441,10 @@ static int _BRPeerAcceptTxMessage(BRPeer *peer, const uint8_t *msg, size_t msgLe

if (txSize > 0 && tx->blockHeight == TX_UNCONFIRMED && feeAmount/txSize < 10) {
//don't relay to wallet
peer_log(peer, "skipping stuck transaction: %s, (low fee: %llu sat/byte)", u256hex(txHash), feeAmount/txSize);
peer_log(peer, "skipping stuck transaction: %s, (low fee: %llu litoshis/byte, min. is 10 litoshis/byte)", u256hex(txHash), feeAmount/txSize);
BRTransactionFree(tx);
if (ctx->rejectedTx) ctx->rejectedTx(ctx->info, txHash, REJECT_LOWFEE);
return 1;
r = 1;
Copy link
Contributor

@andhikayuana andhikayuana May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks @kcw-grunt

Copy link
Collaborator Author

@kcw-grunt kcw-grunt May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks @kcw-grunt
Hey ! You left some crumbs for me @andhikayuana

}
else if (ctx->relayedTx) {
ctx->relayedTx(ctx->info, tx);
Expand Down