Conversation
- Removed nothing test
update references to strings - Readded BIP39 list update rough localization strings Updated the core library move references to critical files
- removed cruft - updated dark light mode for logo - removed extra image
| 249C459E2D936D5900E9C3B0 /* test.c */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.c; path = test.c; sourceTree = "<group>"; }; | ||
| 249C45DA2D936DA600E9C3B0 /* module.modulemap */ = {isa = PBXFileReference; lastKnownFileType = "sourcecode.module-map"; name = module.modulemap; path = ../core/module.modulemap; sourceTree = SOURCE_ROOT; }; | ||
| 249C45DB2D93F23F00E9C3B0 /* service-data.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = "service-data.plist"; sourceTree = "<group>"; }; | ||
| 24B9621B23BA66CF00ECD938 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/MainInterface.strings; sourceTree = "<group>"; }; |
There was a problem hiding this comment.
This extension wasn't used for 5 years in LW and we will re-add in a more modern paradigm
| }() | ||
|
|
||
| private var logo: UIImageView = { | ||
| let image = UIImageView(image: UIImage(named: "bw-logotype-white")) |
There was a problem hiding this comment.
Removed this and now using a theme aware version into the assets catalog
josikie
left a comment
josikie
left a comment
There was a problem hiding this comment.
Looks good. Thank you! @kcw-grunt
There was a problem hiding this comment.
Seems that file was renamed without any changes, we should remove it if we are not using it.
There was a problem hiding this comment.
I was in the middle of adding the dark like themes and changing the asset for dark and light.. Thanks for the look @hassanashraf92
| @@ -1,5 +1,6 @@ | |||
| import UIKit | |||
|
|
|||
| //TBD Deprecated | |||
There was a problem hiding this comment.
Is the full class deprecated? should we remove it?
There was a problem hiding this comment.
Im not good and still worried about how to remove old files @hassanashraf92
We do want to remove cruft. Do you have a recommendation on how to handle?
hassanashraf92
left a comment
hassanashraf92
left a comment
There was a problem hiding this comment.
Approved with 2 comments that can be addressed later.
3 participants
Updates
First apologies for the big changes...please note comments in the PR.
Goals