Skip to content

Techdebt/polish tutorials#82

Merged
kcw-grunt merged 16 commits intodevelopfrom
techdebt/polish-tutorials
Jan 31, 2026
Merged

Techdebt/polish tutorials#82
kcw-grunt merged 16 commits intodevelopfrom
techdebt/polish-tutorials

Conversation

@kcw-grunt
Copy link
Collaborator

@kcw-grunt kcw-grunt commented Jan 26, 2026

📱 Description

This is a further polish of the code so the Tutorials look better.

Platform

  • Android
  • iOS
  • Games-Unity
  • DevOps (AWS)
  • C/Golang

🎯 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔧 Refactoring (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • 🎨 UI/UX improvement
  • ⚡ Performance improvement
  • 🧪 Test addition or improvement

🧪 Tests Status

  • Tests ran successfully locally?
  • Added more tests? How many?
  • Code coverage percentage of the codebase: 9.9%

@kcw-grunt kcw-grunt requested a review from josikie January 26, 2026 20:42
@kcw-grunt kcw-grunt self-assigned this Jan 26, 2026
@@ -0,0 +1,231 @@
# .circleci/config.yml
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added separate config for a weekly run

@@ -0,0 +1,225 @@
# .circleci/config.yml
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added separate config for a daily run

}
}
.opacity(didCopyAddress ? 1.0 : 0.0)
.onChange(of: didCopyAddress) { _ in
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple update to the new Swift API

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted a bunch of garbage files

@kcw-grunt kcw-grunt marked this pull request as ready for review January 31, 2026 09:30
Added a new Modal
Fixing the layout
Lock and Unlock are working but there is no transistion delegate
Removed some unused closures

WIP: Working WalletManager
Layout the address for the receive modal
Wired in the userPreference theme
Refactoring old code
- Finished complete send
- Added top up button action
Added the Walkthrough steps
added .accessibilityIdentifier in many SwiftUI views (Text() , Button())
@kcw-grunt kcw-grunt force-pushed the techdebt/polish-tutorials branch from e517587 to 3b68fd4 Compare January 31, 2026 09:38
Copy link
Collaborator

@josikie josikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! @kcw-grunt

let regularFont: Font = .barlowRegular(size: 24.0)
let largeButtonFont: Font = .barlowBold(size: 24.0)

init(viewModel: LockScreenViewModel, shouldDismiss: Binding<Bool>, didCompleteWipe: Binding<Bool>,) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does viewModel in iOS work the same like ViewModel() in Android?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YeS! It is a design paradigm called MVVM (ModelView ViewModel) and simply means the view (a struct) is the simple display layer while the ViewModel (a class) is where the 'processing' happens. Using this architecture makes dep injection easier and testing easier @josikie .

@kcw-grunt kcw-grunt merged commit 8a5f405 into develop Jan 31, 2026
2 checks passed
@kcw-grunt kcw-grunt deleted the techdebt/polish-tutorials branch January 31, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants