-
Notifications
You must be signed in to change notification settings - Fork 43
[APT-1575] Add captions to our images #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Captions are now displayed beneath images using an _emphasis_ convention, duplicating the value specified as the alt text for the image itself - Both images and captions are now centered on the page - The image lightbox background is now black in the dark theme
|
✔️ Deploy Preview for pensive-meitner-faaeee ready! 🔨 Explore the source changes: 913d5b1 🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61d39f90dfded100075690a9 😎 Browse the preview: https://deploy-preview-122--pensive-meitner-faaeee.netlify.app |
| margin: auto; | ||
| } | ||
|
|
||
| img + em { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't familiar with this selector - what does it mean to have img + em is it:
<em><img /> </em>
```?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it selects the latter element (after the +) when it appears immediately following the former, e.g.
<img … />
<em>…</em>
Better stated: it selects any em preceded by an img. (Notably, the inverse is not currently possible.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
I'm closing this in favor of #125, which achieves the same result with a plugin to avoid the redundant text in the source file. |
duplicating the value specified as the alt text for the image itself