Skip to content

Conversation

@ebeneliason
Copy link
Contributor

  • Captions are now displayed beneath images using an emphasis convention,
    duplicating the value specified as the alt text for the image itself
  • Both images and captions are now centered on the page
  • The image lightbox background is now black in the dark theme

- Captions are now displayed beneath images using an _emphasis_ convention,
  duplicating the value specified as the alt text for the image itself
- Both images and captions are now centered on the page
- The image lightbox background is now black in the dark theme
@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for pensive-meitner-faaeee ready!

🔨 Explore the source changes: 913d5b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61d39f90dfded100075690a9

😎 Browse the preview: https://deploy-preview-122--pensive-meitner-faaeee.netlify.app

margin: auto;
}

img + em {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't familiar with this selector - what does it mean to have img + em is it:

<em><img /> </em>
```?

Copy link
Contributor Author

@ebeneliason ebeneliason Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it selects the latter element (after the +) when it appears immediately following the former, e.g.

<img … />
<em>…</em>

Better stated: it selects any em preceded by an img. (Notably, the inverse is not currently possible.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@oredavids oredavids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ebeneliason
Copy link
Contributor Author

I'm closing this in favor of #125, which achieves the same result with a plugin to avoid the redundant text in the source file.

@ebeneliason ebeneliason closed this Jan 4, 2022
@oredavids oredavids deleted the apt-1575-captions branch May 17, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants