Skip to content

Conversation

ebeneliason
Copy link
Contributor

The plugin identifies image content in the page with alt text specified,
and injects a new emphasis node immediately following containing that text.

The plugin identifies image content in the page with alt text specified,
and injects a new emphasis node immediately following containing that text.
@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for pensive-meitner-faaeee ready!

🔨 Explore the source changes: 435fd42

🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61d4d845dc7b8c0008c081bc

😎 Browse the preview: https://deploy-preview-125--pensive-meitner-faaeee.netlify.app

oredavids
oredavids previously approved these changes Jan 4, 2022
Copy link
Contributor

@oredavids oredavids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ebeneliason
Copy link
Contributor Author

Thanks @oredavids! Would you mind re-stamping? I pushed a new commit with better comments to really explain how it all works for posterity.

@ebeneliason ebeneliason merged commit 9cbeaea into master Jan 4, 2022
@ebeneliason ebeneliason deleted the apt-1575-captions-plugin branch January 4, 2022 23:54
@eak12913
Copy link
Contributor

eak12913 commented Jan 5, 2022

@ebeneliason this is great - but is this a plugin that you wrote? Or is this something that we sourced from the official image caption plugin and possibly adapted to have proper imports? If we sourced it from the original - we should document that and explain why we had to write our own, when there's an image caption remark plugin already available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants