-
Notifications
You must be signed in to change notification settings - Fork 44
Sidebar index for our guides #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for pensive-meitner-faaeee ready! 🔨 Explore the source changes: 828c575 🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61ef29408d2f8f00072a27a4 😎 Browse the preview: https://deploy-preview-148--pensive-meitner-faaeee.netlify.app |
b10ce04
to
08941ed
Compare
I think this is finally ready for review. I've squashed it down into two commits. The first introduces the new guides sidebar and index pages, adds back buttons to guides, and cleans up some styling. The second shuffles the RefArch guide down one level (so it reflects the patterns of other guide categories), updates its naming, and adds an admonition to clarify that it's just an example. Note: this change creates two cards for guides that don't exist yet, but will soon:
As such, we wouldn't want to release this until those are merged as well, but the cards should become active once the other PRs land. |
08941ed
to
8650dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spot checked as much as I could and don't see any glaring issues. The only comment I'll make is that the style guides end up without any sidebar and therefore there's no "back" button from them. They are "flatter" than the other guides - so I'm pretty sure that the issue here is that there's nowhere to put a "back" button when there's no sidebar - and no sidebar is needed on those pages.
I guess my only comment is that perhaps we'll need another back button solution for pages without a sidebar? Or perhaps we have a sidebar of exactly two items: the back button and the category index page?
8650dcd
to
7489ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed live.
No description provided.