Skip to content

Conversation

ebeneliason
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for pensive-meitner-faaeee ready!

🔨 Explore the source changes: 828c575

🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61ef29408d2f8f00072a27a4

😎 Browse the preview: https://deploy-preview-148--pensive-meitner-faaeee.netlify.app

@ebeneliason ebeneliason force-pushed the guides-index-sidebar branch 2 times, most recently from b10ce04 to 08941ed Compare January 21, 2022 23:18
@ebeneliason ebeneliason changed the title WIP: Sidebar index for our guides Sidebar index for our guides Jan 21, 2022
@ebeneliason
Copy link
Contributor Author

ebeneliason commented Jan 21, 2022

I think this is finally ready for review. I've squashed it down into two commits. The first introduces the new guides sidebar and index pages, adds back buttons to guides, and cleans up some styling. The second shuffles the RefArch guide down one level (so it reflects the patterns of other guide categories), updates its naming, and adds an admonition to clarify that it's just an example.

Note: this change creates two cards for guides that don't exist yet, but will soon:

  1. The Gruntwork Production Framework
  2. The Reference Architecture Setup Guide

As such, we wouldn't want to release this until those are merged as well, but the cards should become active once the other PRs land.

eak12913
eak12913 previously approved these changes Jan 24, 2022
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spot checked as much as I could and don't see any glaring issues. The only comment I'll make is that the style guides end up without any sidebar and therefore there's no "back" button from them. They are "flatter" than the other guides - so I'm pretty sure that the issue here is that there's nowhere to put a "back" button when there's no sidebar - and no sidebar is needed on those pages.

I guess my only comment is that perhaps we'll need another back button solution for pages without a sidebar? Or perhaps we have a sidebar of exactly two items: the back button and the category index page?

Copy link
Contributor

@oredavids oredavids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed live.

@ebeneliason ebeneliason merged commit e03f925 into master Jan 24, 2022
@ebeneliason ebeneliason deleted the guides-index-sidebar branch January 24, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants