Skip to content

Conversation

@bethadele
Copy link
Contributor

Finally adding this page to the docs site! Please take a look -- I think I made the right tweaks to get the page into the nav, but I haven't updated the docs site before so definitely check my work.

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for pensive-meitner-faaeee ready!

Name Link
🔨 Latest commit 725c574
🔍 Latest deploy log https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/645d150045435a0008468784
😎 Deploy Preview https://deploy-preview-725--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

oredavids
oredavids previously approved these changes Apr 13, 2023
Copy link
Contributor

@oredavids oredavids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown file and sidebar update look good.

@ebeneliason
Copy link
Contributor

Glad to see this! A couple of style notes:

  • Should the bold lines of text preceding each section be implemented as headers instead?
  • Should we use ordered lists so that we can refer to these as e.g. section "4.b"?

@oredavids
Copy link
Contributor

@bethadele reminder to look at @ebeneliason's suggestions.

@zackproser
Copy link
Contributor

@ebeneliason, @oredavids and I have implemented your requested changes, and I've fixed up a bunch of voice mismatches and simplified / clarified where possible.

I think this is ready for another look!

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@zackproser
Copy link
Contributor

Thanks for review!

@oredavids oredavids merged commit 4531009 into master May 11, 2023
@oredavids oredavids deleted the srm branch May 11, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants