-
Notifications
You must be signed in to change notification settings - Fork 43
feat(CORE-876 & CORE-865): Implement module search and display all modules #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CORE-876 & CORE-865): Implement module search and display all modules #850
Conversation
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
fixed the redundant blue focus, thanks!
✅
We don't have the
✅
Working on this.
✅
Got it, thanks!
I'm personally a fan of the sidebar, but if we want to collapse it, I'm fine with that.
Sounds good, thanks! |
I'm confused by this. Searching by topic already appears to work. I realize we don't have "use cases" in our search index, but the idea here would just be to hard-code a grouping of our topic list into those three use case areas purely for display within the menu itself, at least for now.
Let's talk about this more before acting on it. Josh has actually proposed eliminating the browsable sidebar in favor of a bespoke filter sidebar (where you could e.g. check and uncheck various topics and other filter options instead of the dropdown). That's clearly not in scope here — I bring it up just to call out that we may consider the UI of this reference section more holistically at some point. |
Let's chat offline. Perhaps I'm confused as well. |
bf81b2b to
98dc50f
Compare
src/components/SearchArea.tsx
Outdated
| export const SearchArea: React.FunctionComponent< | ||
| PropsWithChildren<SearchAreaProps> | ||
| > = ({ name, requirement, type, children }) => { | ||
| // TODO: Make using a configuration work here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we want to leave this TODO in as a future reminder or pull out from this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im pulling it out now, i forgot to do it before i removed the WIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Looking good! I suggest shortening the intro blurb considerably. I would have made this a suggestion on the PR but the unchanged sentence in the middle made that impossible.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✅
✅
✅
Will ping you on this
Looks like they are long enough that it's wrapping lines and the background color is continuing on across the whole line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What it is
Adds module search to Library reference landing page