Skip to content

Conversation

@ohlsont
Copy link
Contributor

@ohlsont ohlsont commented Apr 6, 2020

This PR fixes issue issue #45

Progress on file download makes downloading large files much easier as feedback
is given once per second now.

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement, thanks!

@ohlsont ohlsont force-pushed the add-progress-pr branch 4 times, most recently from 0d46678 to c2de0e0 Compare April 9, 2020 06:58
@ohlsont ohlsont requested a review from brikis98 April 9, 2020 06:58
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks great, thank you! I'll kick off tests now.

@brikis98
Copy link
Member

One test failed:

=== RUN   TestEmptyOptionValues
Incorrect Usage. invalid boolean value "" for -progress: strconv.ParseBool: parsing "": invalid syntax

NAME:
   main_test - A new cli application

USAGE:
   fetch.test [global options] command [command options] [arguments...]

VERSION:
   0.0.0

COMMANDS:
     help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --repo value                         
   --commit value                       
   --branch value                       
   --tag value                          
   --github-oauth-token value            [$GITHUB_OAUTH_TOKEN]
   --source-path value                  
   --release-asset value                
   --release-asset-checksum value       
   --release-asset-checksum-algo value  
   --github-api-version value           (default: "v3")
   --progress                           
   --help, -h                           show help
   --version, -v                        print the version
--- FAIL: TestEmptyOptionValues (0.00s)
	main_test.go:137: Expected 'You specified the --progress flag but did not provide any value.' but received 'invalid boolean value "" for -progress: strconv.ParseBool: parsing "": invalid syntax'

Progress makes downloading large files much easier as feedback
is given once per second now.
@ohlsont
Copy link
Contributor Author

ohlsont commented Apr 14, 2020

One test failed:

=== RUN   TestEmptyOptionValues
Incorrect Usage. invalid boolean value "" for -progress: strconv.ParseBool: parsing "": invalid syntax

NAME:
   main_test - A new cli application

USAGE:
   fetch.test [global options] command [command options] [arguments...]

VERSION:
   0.0.0

COMMANDS:
     help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --repo value                         
   --commit value                       
   --branch value                       
   --tag value                          
   --github-oauth-token value            [$GITHUB_OAUTH_TOKEN]
   --source-path value                  
   --release-asset value                
   --release-asset-checksum value       
   --release-asset-checksum-algo value  
   --github-api-version value           (default: "v3")
   --progress                           
   --help, -h                           show help
   --version, -v                        print the version
--- FAIL: TestEmptyOptionValues (0.00s)
	main_test.go:137: Expected 'You specified the --progress flag but did not provide any value.' but received 'invalid boolean value "" for -progress: strconv.ParseBool: parsing "": invalid syntax'

Ah, some tests can be run locally. That one works now anyways :). @brikis98 can you rerun the tests?

@ohlsont
Copy link
Contributor Author

ohlsont commented Apr 22, 2020

@brikis98?

@josh-padnick
Copy link
Contributor

FYI, brikis98 is on vacation for this week but he'll be back next week.

@ohlsont
Copy link
Contributor Author

ohlsont commented Apr 23, 2020

FYI, brikis98 is on vacation for this week but he'll be back next week.

Ah, @josh-padnick I just want a rerun of the tests. Maybe you could help out?

@brikis98
Copy link
Member

I'm back now, thanks for waiting!

Just kicked off the tests again.

@brikis98
Copy link
Member

Tests passed! Merging now, thanks!

@brikis98 brikis98 merged commit da4a2b6 into gruntwork-io:master Apr 27, 2020
@brikis98
Copy link
Member

@brikis98 brikis98 mentioned this pull request Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants