-
Notifications
You must be signed in to change notification settings - Fork 93
Add progress to file download #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
brikis98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement, thanks!
0d46678 to
c2de0e0
Compare
brikis98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks great, thank you! I'll kick off tests now.
|
One test failed: |
Progress makes downloading large files much easier as feedback is given once per second now.
8e1417e to
9cdda9c
Compare
Ah, some tests can be run locally. That one works now anyways :). @brikis98 can you rerun the tests? |
|
FYI, brikis98 is on vacation for this week but he'll be back next week. |
Ah, @josh-padnick I just want a rerun of the tests. Maybe you could help out? |
|
I'm back now, thanks for waiting! Just kicked off the tests again. |
|
Tests passed! Merging now, thanks! |
This PR fixes issue issue #45
Progress on file download makes downloading large files much easier as feedback
is given once per second now.