Bump kramdown from 2.2.1 to 2.3.0 #353
Conversation
Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.2.1 to 2.3.0. - [Release notes](https://github.com/gettalong/kramdown/releases) - [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page) - [Commits](https://github.com/gettalong/kramdown/commits) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
eak12913,
josh-padnick,
oredavids and
tsmit291
as code owners
|
Deploy preview for keen-clarke-470db9 ready! Built with commit c1c9e9f |
|
@oredavids or @eak12913 Could one of you take a look at this and merge? |
|
I'm not sure what the deal is with this change - but I'm observing a "weridness" in the preview environment. Every time I navigate from page to page, it appears like there's a "zooming" effect that's happening on our header and links. I don't know if this is due to the upgraded version of this library but I'm not observing the same issue in production. |
|
Any movement on this? Is it worth prioritizing? Should we reflect this in our Jira board for the website? |
|
I was seeing some issues when I tried to click around on the site. Once I
saw the issues, I didn't feel like it was safe to merge without further
investigation. Can either you or Ore please see if you also see the issues
I saw in my earlier message?
Priority wise, I think this falls pretty low given the other stuff we're
working on.
…On Tue, Sep 8, 2020 at 5:17 PM Josh Padnick ***@***.***> wrote:
Any movement on this? Is it worth prioritizing? Should we reflect this in
our Jira board for the website?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIGCCE6JFFOOPGAJJPNNHYTSE2NPFANCNFSM4PYDUXYQ>
.
|
|
@eak12913 I can't reproduce the behavior you found. Can you see if this is still an issue, and if so record a screencap of it happening? |
|
@josh-padnick here's a screencap: https://www.loom.com/share/cb7e4ae3618d4a6882381b611db8f868 |
|
That's really strange, but I think I have seen this before. Perhaps it doesn't happen in prod because we've got CloudFront. Given how this change shouldn't affect anything, I'm inclined to publish this. @oredavids Any add'l thoughts? |
|
My vote is that we merge this since it shouldn't have anything to do with the weird "zooming" behavior we experienced. Any objections? Seems easy enough to reverse if needed and will clear the "vulnerability alert" from our repo. |
Bumps kramdown from 2.2.1 to 2.3.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.