[WWW-92] Pipelines subpage #375

klijakub · 2020-11-12T18:17:01Z

Hello,

new pipelines subpage ( /pipelines routing)
added new assets from the approved design
features section

Jira Item: WWW-92

netlify · 2020-11-12T18:17:55Z

Deploy preview for keen-clarke-470db9 ready!

Built with commit 1eadb48

https://deploy-preview-375--keen-clarke-470db9.netlify.app

eak12913 · 2020-11-17T02:39:06Z

@klijakub I'm not sure if this is just something on my end - but the terraform plan and terraform apply seem like they are much larger than the surrounding text. See the screenshot:

I think @josh-padnick will be the primary person to review this - but just stood out to me as a little odd. You may want to make it a bit smaller.

josh-padnick · 2020-11-18T06:27:29Z

Thanks for submitting this PR! I just submitted a commit with the final set of changes, and this is now ready to merge.

@eak12913 @oredavids Could one of you approve and merge this as I'm now a contributor?

@klijakub There is still one additional change to make. We actually got some extra feedback on the main image. Could you make the following updates to that image?

Remove the Lambda function from the diagram
Change "CI Server" to "Your CI Server"
Add another label to the CI Server called "Pipelines CLI" with the Grunty logo
Add another label "Your Terraform Code" to the Terraform logo

klijakub · 2020-11-18T10:18:50Z

Thanks for submitting this PR! I just submitted a commit with the final set of changes, and this is now ready to merge.

@eak12913 @oredavids Could one of you approve and merge this as I'm now a contributor?

@klijakub There is still one additional change to make. We actually got some extra feedback on the main image. Could you make the following updates to that image?

Remove the Lambda function from the diagram

Change "CI Server" to "Your CI Server"

Add another label to the CI Server called "Pipelines CLI" with the Grunty logo

Add another label "Your Terraform Code" to the Terraform logo

@josh-padnick
Thanks for the review! :) Sure I will let know our design team and we will get back to you with the new diagram

brikis98

Just added a few trivial grammar NITs

_data/pipelines-features.yml

pages/pipelines/_docs.html

pages/pipelines/_sub-hero.html

_data/pipelines-features.yml

klijakub · 2020-11-18T11:19:58Z

@brikis98 fixed! :)

@josh-padnick the new diagram is ready and committed:

eak12913 · 2020-11-18T14:04:36Z

@klijakub Could you please update your branch and then I can approve it? Otherwise I believe my approval may be dismissed if you push additional commits after I approve.

Thanks and then I'll be able to approve and merge!

klijakub · 2020-11-18T16:59:05Z

@klijakub Could you please update your branch and then I can approve it? Otherwise I believe my approval may be dismissed if you push additional commits after I approve.

Thanks and then I'll be able to approve and merge!

Sorry, didn't notice your comment. Sure, I will do it asap

josh-padnick · 2020-11-18T17:18:19Z

@klijakub Thanks for the fast turnaround! Ok, just one more minor change. Can you modify "Pipelines CLI" to "Gruntwork Pipelines CLI"? Otherwise, everything looks great.

josh-padnick · 2020-11-18T17:19:29Z

@eak12913 Could you give me another approval? Had to resolve merge conflicts before I could merge.

eak12913

Rubber stamping. Thanks!

josh-padnick · 2020-11-18T17:30:46Z

@oredavids Sorry, looks like I need yet one more non-contributor approval here...not sure why?

klijakub · 2020-11-18T18:46:12Z

@klijakub Thanks for the fast turnaround! Ok, just one more minor change. Can you modify "Pipelines CLI" to "Gruntwork Pipelines CLI"? Otherwise, everything looks great.

Done ;)

josh-padnick · 2020-11-18T19:18:19Z

Thanks for the fast turnaround! This is ready to merge once we can get one more non-contributor approval.

josh-padnick · 2020-11-19T20:54:05Z

@eak12913 Could you (a) resolve this merge conflict, and (b) coordinate with another (non-contributor) Grunt to get this deployed?

eak12913 · 2020-11-19T21:29:54Z

I will take a look!

….github.io into pipelines # Conflicts: # assets/css/prism.css

eak12913 · 2020-11-19T21:45:53Z

@josh-padnick @klijakub: I just cloned Altology's fork of this repo and tried to resolve the conflict (which I was able to do) but I can't actually push to this repo.

Pushing to https://github.com/Altalogy/gruntwork-io.github.io.git
remote: Permission to Altalogy/gruntwork-io.github.io.git denied to eak12913.
fatal: unable to access 'https://github.com/Altalogy/gruntwork-io.github.io.git/': The requested URL returned error: 403

The fix is simple - for prism.css just accept what's coming from Gruntwork. I'm not even sure if it needed to change in this PR as we don't appear to be using prism to render any code on the Pipelines page.

klijakub · 2020-11-20T15:59:40Z

@josh-padnick @klijakub: I just cloned Altology's fork of this repo and tried to resolve the conflict (which I was able to do) but I can't actually push to this repo.
Pushing to https://github.com/Altalogy/gruntwork-io.github.io.git
remote: Permission to Altalogy/gruntwork-io.github.io.git denied to eak12913.
fatal: unable to access 'https://github.com/Altalogy/gruntwork-io.github.io.git/': The requested URL returned error: 403
The fix is simple - for prism.css just accept what's coming from Gruntwork. I'm not even sure if it needed to change in this PR as we don't appear to be using prism to render any code on the Pipelines page.

Oh sorry, @eak12913 , you weren't a member of the forked repo, I sent you an invite, please let me know if you're able now?

eak12913 · 2020-11-20T16:40:49Z

Thanks @klijakub! I'm in and was able to push. Now - I don't think that I will be able approve this - so we may need someone else to come and help us. @josh-padnick @oredavids ?

eak12913

I checked all the pages and saw no weird prism CSS issues (checked Guides, LZ page and the pipelines page)

josh-padnick · 2020-11-20T20:56:38Z

Ugh, I'm a contributor now. @oredavids can you approve?

oredavids

Rubber stamp.

ArkuVonSymfon and others added 9 commits October 29, 2020 11:20

created pipelines page

33bea94

creating features section

5260020

added chart to sub-hero section

a695bf8

added pipelines page to navbar and footer

ac53378

added links to docs and pricing

ec95b80

added pricing link

8b83a22

styles and ga-event fixed

091eb95

removed logos from features

40b8a9a

New assets, styles edits

2b9fe3d

klijakub requested review from eak12913, josh-padnick, oredavids and tsmit291 as code owners November 12, 2020 18:17

klijakub and others added 5 commits November 17, 2020 14:23

font size and family problem fixed

96fc62e

span margin edit

27124d2

Merge branch 'master' into pipelines

35dbe0b

Add final improvements to pipelines page.

ed7774d

Additional tweaks.

381b304

josh-padnick previously approved these changes Nov 18, 2020

View reviewed changes

Re-order nav.

178e89b

josh-padnick dismissed their stale review via 178e89b November 18, 2020 06:38

brikis98 reviewed Nov 18, 2020

View reviewed changes

grammar changes, new diagram

06b7ab8

Merge branch 'master' into pipelines

9c18a8e

eak12913 previously approved these changes Nov 18, 2020

View reviewed changes

Merge branch 'master' into pipelines

74247ef

Pipelines diagram edits

6785457

klijakub dismissed eak12913’s stale review via 6785457 November 18, 2020 18:45

Merge branch 'master' of https://github.com/gruntwork-io/gruntwork-io…

defb1b2

….github.io into pipelines # Conflicts: # assets/css/prism.css

Merge branch 'master' into pipelines

1eadb48

eak12913 approved these changes Nov 20, 2020

View reviewed changes

oredavids approved these changes Nov 20, 2020

View reviewed changes

eak12913 merged commit 4ac3142 into gruntwork-io:master Nov 20, 2020

eak12913 deleted the pipelines branch November 20, 2020 21:46

Uh oh!

[WWW-92] Pipelines subpage #375

[WWW-92] Pipelines subpage #375

Uh oh!

Conversation

klijakub commented Nov 12, 2020

Uh oh!

netlify bot commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eak12913 commented Nov 17, 2020

Uh oh!

josh-padnick commented Nov 18, 2020

Uh oh!

klijakub commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brikis98 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

klijakub commented Nov 18, 2020

Uh oh!

eak12913 commented Nov 18, 2020

Uh oh!

klijakub commented Nov 18, 2020

Uh oh!

josh-padnick commented Nov 18, 2020

Uh oh!

josh-padnick commented Nov 18, 2020

Uh oh!

eak12913 left a comment

Choose a reason for hiding this comment

Uh oh!

josh-padnick commented Nov 18, 2020

Uh oh!

klijakub commented Nov 18, 2020

Uh oh!

josh-padnick commented Nov 18, 2020

Uh oh!

josh-padnick commented Nov 19, 2020

Uh oh!

eak12913 commented Nov 19, 2020

Uh oh!

eak12913 commented Nov 19, 2020

Uh oh!

klijakub commented Nov 20, 2020

Uh oh!

eak12913 commented Nov 20, 2020

Uh oh!

eak12913 left a comment

Choose a reason for hiding this comment

Uh oh!

josh-padnick commented Nov 20, 2020

Uh oh!

oredavids left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

netlify bot commented Nov 12, 2020 •

edited

Loading

klijakub commented Nov 18, 2020 •

edited

Loading