-
-
Notifications
You must be signed in to change notification settings - Fork 42
[WWW-93] Landing zone page #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for keen-clarke-470db9 ready! Built with commit e4fed0f |
99aaaed to
f506a38
Compare
|
This is now ready to merge! @oredavids @eak12913 Could you approve and merge this as non-contributor? |
eak12913
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamping!
eak12913
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folks - I'm unable to merge this because it's out of date with the base branch.
|
@eak12913 please check now, I've updated ;) |
|
@klijakub - Thank you. I'm keeping an eye on this. Our internal script is having a tough time at the moment and I'm actually unable to merge this PR until that script completes. As soon as we resolve the issue we will merge! |
|
@klijakub one more favor - can you push some test/nothing commit to this branch and then push something else to undo it...ie - put "test" into a README...and then revert that. We can try to use this to re-trigger the "non-contributor" approval script that's failing to run here |
eak12913
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamping so we can merge
|
@klijakub Thank you. Merged! |
Hello,
Jira Item: [WWW-93]
[WWW-93]: https://gruntwork.atlassian.net/browse/WWW-93