Skip to content

Conversation

@klijakub
Copy link
Contributor

Hello,

  • landing zone for aws subpage is ready
  • added new assets from the approved design

Jira Item: [WWW-93]
[WWW-93]: https://gruntwork.atlassian.net/browse/WWW-93

@netlify
Copy link

netlify bot commented Nov 13, 2020

Deploy preview for keen-clarke-470db9 ready!

Built with commit e4fed0f

https://deploy-preview-376--keen-clarke-470db9.netlify.app

@josh-padnick
Copy link
Contributor

This is now ready to merge! @oredavids @eak12913 Could you approve and merge this as non-contributor?

eak12913
eak12913 previously approved these changes Nov 18, 2020
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping!

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks - I'm unable to merge this because it's out of date with the base branch.

@klijakub
Copy link
Contributor Author

@eak12913 please check now, I've updated ;)

@eak12913
Copy link
Contributor

@klijakub - Thank you. I'm keeping an eye on this. Our internal script is having a tough time at the moment and I'm actually unable to merge this PR until that script completes. As soon as we resolve the issue we will merge!

@eak12913
Copy link
Contributor

@klijakub one more favor - can you push some test/nothing commit to this branch and then push something else to undo it...ie - put "test" into a README...and then revert that. We can try to use this to re-trigger the "non-contributor" approval script that's failing to run here

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping so we can merge

@eak12913 eak12913 merged commit 40c898d into gruntwork-io:master Nov 18, 2020
@eak12913
Copy link
Contributor

@klijakub Thank you. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants