Fix Code rendering on Guides pages #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the visual issues on the guides pages where all of the code blocks were rendered improperly. The root cause of the issue is that Prism is a library used for automatically syntax highlighting code in <code> blocks. This functionality was already being used by our Guides pages to render code. The new Landing Zone page also uses this library but wanted to provide a custom theme. The latter page introduction updated the css and unintentionally overrode the styles for Guides. This PR brings back the notion of a "default" prism theme and then exposes a page variable that a page can set to have a custom prism theme on a per-page basis.
eak12913
requested review from
josh-padnick,
oredavids and
tsmit291
as code owners
|
Deploy preview for keen-clarke-470db9 ready! Built with commit c502b08 |
josh-padnick
approved these changes
Nov 18, 2020
Contributor
josh-padnick
left a comment
josh-padnick
left a comment
There was a problem hiding this comment.
Awesome turnaround time on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the visual issues on the guides pages where all of the code blocks were rendered improperly.
The root cause of the issue is that Prism is a library used for automatically syntax highlighting code in
<code>blocks. This functionality was already being used by our Guides pages to render code. The new Landing Zone page also uses this library but wanted to provide a custom theme. The latter page introduction updated the css and unintentionally overrode the styles for Guides.This PR brings back the notion of a "default" prism theme and then exposes a page variable that a page can set to have a custom prism theme on a per-page basis.