Remove links to our -public repos #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
requested review from
eak12913,
josh-padnick,
oredavids and
tsmit291
as code owners
|
Deploy preview for keen-clarke-470db9 ready! Built with commit fb5b40a |
eak12913
reviewed
Nov 20, 2020
|
|
||
| set -e | ||
|
|
||
| bundle exec jekyll build --incremental |
Contributor
There was a problem hiding this comment.
@josh-padnick added this recently as an optimization. Is this not necessary?
Member
Author
There was a problem hiding this comment.
AFAIK it works without it...
eak12913
approved these changes
Nov 20, 2020
Contributor
eak12913
left a comment
eak12913
left a comment
There was a problem hiding this comment.
One small question but otherwise I spot checked the links and was not able to find any broken ones. LGTM!
Member
Author
|
Thanks for the review! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of cleaning up the
-publicrepos, we need to remove any inbound links to them. This PR updates the IaC Lib page to replace this links with links to our repo browser. As a bonus, I also add repo browser links to all our repos, and fix broken links on a few items.