Skip to content

Conversation

@yorinasub17
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Dec 18, 2020

✔️ Deploy preview for keen-clarke-470db9 ready!

🔨 Explore the source changes: 0c58a2b

🔍 Inspect the deploy logs: https://app.netlify.com/sites/keen-clarke-470db9/deploys/5fdd1ad065229b00085328ee

😎 Browse the preview: https://deploy-preview-385--keen-clarke-470db9.netlify.app

Reference Architecture work with Terraform 0.13:

Standard Reference Architecture::
See the https://github.com/gruntwork-io/infrastructure-modules-multi-account-acme/pull/46[infrastructure-modules PR]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: perhaps include migration instructions and both PRs? i.e., Guide + 2 examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point! Adjusted: 0c58a2b

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit d7999c7 into master Dec 18, 2020
@yorinasub17 yorinasub17 deleted the yori-upgrade-guide branch December 18, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants