Update Nokogiri dependency #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updated the dependency for the nokogiri library. This is a library used by the `jekyll-toc` plugin and is not used directly. The reason to update the version of nokogiri is because of a security notification from Dependabot. I don't believe that there's any issues from making this update.
eak12913
requested review from
josh-padnick,
oredavids and
tsmit291
as code owners
|
✔️ Deploy preview for keen-clarke-470db9 ready! 🔨 Explore the source changes: d3009e0 🔍 Inspect the deploy logs: https://app.netlify.com/sites/keen-clarke-470db9/deploys/5fff4ceab9cfe90007de97b5 😎 Browse the preview: https://deploy-preview-393--keen-clarke-470db9.netlify.app |
Contributor
Author
|
@oredavids Could you please take a look here and approve if you think it looks good? Thanks! |
oredavids
approved these changes
Jan 28, 2021
Contributor
oredavids
left a comment
oredavids
left a comment
There was a problem hiding this comment.
LGTM & I don't see any errors in the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated the dependency for the nokogiri library. This is a library used by the
jekyll-tocplugin and is not used directly. The reason to update the version of nokogiri is because of a security notification from Dependabot. I don't believe that there's any issues from making this update.