-
-
Notifications
You must be signed in to change notification settings - Fork 42
Add patcher use cases page #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for keen-clarke-470db9 ready! 🔨 Explore the source changes: dd41140 🔍 Inspect the deploy log: https://app.netlify.com/sites/keen-clarke-470db9/deploys/611a44f054c03b00073596ed 😎 Browse the preview: https://deploy-preview-583--keen-clarke-470db9.netlify.app |
brikis98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting started on this Ana!
Some thoughts:
- Having this on a separate page makes total sense. We should have something like "Use Cases" in the nav.
- Only the initial landing page should use the big blue hero section at the top and the list of customers towards the bottom. All other pages use a simpler, dark hero text at the top. E.g., See https://www.gruntwork.io/hipaa-compliance-on-aws/why-gruntwork.
|
|
||
| - id: patch | ||
| title: Patch | ||
| content: https://i.imgur.com/mxEkeHw.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: instead of an image, for code, it's more legible to include an actual code snippet in <pre> and <code> tags. See here for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling getting this to work, as currently the tabbed divs support either images only or code tabs only, but not a mix of the two. Since it's a 'NIT' I'll leave this as is for now.
Done in e25424f. |
|
OK, I addressed everything but this NIT - this is ready for another round of reviews! |
|
hey @infraredgirl, I reviewed your new standalone page. Overall I think the page reads very well from top to bottom, so good job! My minor feedback:
|
brikis98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, page is shaping up very nicely!
I re-recorded the gif. Not sure if it's any better now. If it's still not acceptable, then I'd ask for someone to help me out with this one.
Got it, thanks!
I think I'll leave this one for a follow up. |
|
This is ready for another round of reviews! |
brikis98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good enough point to merge and release. I think we can file bugs and fix the other issues (e.g., blurry image) after. Thanks Ana!
|
Awesome, thanks all! I'll merge, release, and file bugs. |

Closes #546.
Link to preview: https://deploy-preview-583--keen-clarke-470db9.netlify.app/patcher/use-cases/
Open quesitons / still TODO:
bodyblocks?