Efield lepton updates#3
Merged
gsalkuin merged 4 commits intogsalkuin:developfrom Jan 15, 2025
Merged
Conversation
gsalkuin
approved these changes
Jan 15, 2025
gsalkuin
pushed a commit
that referenced
this pull request
Mar 4, 2025
Kokkos SNAP grid local compute
gsalkuin
pushed a commit
that referenced
this pull request
Apr 29, 2025
…etup-python-5 Bump actions/setup-python from 4 to 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first two commits streamline code for easier future debugging and development, making the following changes:
phianddphi(previously one set of arrays was initialized as true and the other false; this is asking for a future dev to introduce a bug!)phianddphiwith two flag-checks per inner loop (acceptable, to me, to avoid future bugs if one set of duplicate code is updated but not another).The last two commits propose a completely different way of updating the Lepton expression references -- by getting the pointer to each reference returned by
getVariableReference, making the update process smoother in the subsequent repeated force loops. In my opinion this is nicer and more maintainable code -- BUT that is just my opinion so I am okay for this commit to be reverted.