Remove browser automation from daemon

[glittercowboy]

Summary

• Removes daemon-side browser automation runtime management, RPC handling, runtime probing, and environment wiring.
• Removes the Pi gsd_browser extension tool package and browser-specific task/session context.
• Bumps github.com/gsd-build/protocol-go to v0.37.0.

Verification

• go test ./...
• npm test in internal/pi/extension
• git diff --check
• rg residual scan for browser automation identifiers

Dependency

• Depends on merged protocol-go PR: Remove browser automation protocol protocol-go#46
• Uses protocol-go tag: v0.37.0

Summary by CodeRabbit

• Refactor

  • Removed browser automation feature and related command-line options.

• Chores

  • Updated protocol library dependency to v0.37.0.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 49649282-c3d1-4201-8bc3-d0b1a49b5d85

📥 Commits

Reviewing files that changed from the base of the PR and between 7995675 and 4c19443.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (30)

• cmd/pi_tui.go
• go.mod
• internal/browser/manager.go
• internal/browser/manager_test.go
• internal/browser/runtime_probe.go
• internal/browser/runtime_probe_test.go
• internal/browser/safety.go
• internal/browser/safety_test.go
• internal/browser/service.go
• internal/browser/types.go
• internal/browser/updater.go
• internal/browser/updater_test.go
• internal/loop/browser_rpc.go
• internal/loop/daemon.go
• internal/loop/daemon_test.go
• internal/pi/executor.go
• internal/pi/extension/browser-extension.ts
• internal/pi/extension/browser-methods.generated.test.mjs
• internal/pi/extension/browser-methods.generated.ts
• internal/pi/extension/browser-methods.ts
• internal/pi/extension/browser-tool.test.mjs
• internal/pi/extension/gsd-browser-skill/SKILL.md
• internal/pi/extension/index.ts
• internal/pi/extension_package_test.go
• internal/pi/worker_key.go
• internal/pi/worker_key_test.go
• internal/relay/conn.go
• internal/session/actor.go
• internal/session/browser_tool_test.go
• scripts/package-pi-extension.sh

💤 Files with no reviewable changes (24)

• internal/pi/extension/browser-methods.ts
• internal/browser/updater_test.go
• internal/pi/extension/browser-methods.generated.test.mjs
• internal/browser/runtime_probe_test.go
• internal/pi/extension/gsd-browser-skill/SKILL.md
• internal/browser/safety_test.go
• cmd/pi_tui.go
• internal/pi/extension/browser-methods.generated.ts
• internal/browser/safety.go
• internal/loop/daemon_test.go
• internal/loop/browser_rpc.go
• internal/browser/manager_test.go
• internal/session/browser_tool_test.go
• internal/pi/extension/browser-tool.test.mjs
• scripts/package-pi-extension.sh
• internal/pi/worker_key_test.go
• internal/pi/extension/browser-extension.ts
• internal/browser/types.go
• internal/pi/extension_package_test.go
• internal/browser/updater.go
• internal/browser/manager.go
• internal/pi/worker_key.go
• internal/browser/runtime_probe.go
• internal/browser/service.go

✅ Files skipped from review due to trivial changes (1)

• go.mod

🚧 Files skipped from review as they are similar to previous changes (1)

• internal/pi/extension/index.ts

---

📝 Walkthrough

Walkthrough

Browser subsystem removal across Go and TypeScript codebase: manager, service, safety, runtime probe, updater packages deleted; browser integration removed from daemon loop, Pi executor, sessions, relay; browser extension wiring removed; browser CLI flags removed; all related tests deleted.

Changes

Browser Subsystem Removal

Layer / File(s)	Summary
Browser Package Core internal/browser/manager.go, internal/browser/service.go, internal/browser/types.go, internal/browser/safety.go, internal/browser/runtime_probe.go, internal/browser/updater.go	Entire browser package implementation deleted: session/grant lifecycle management, browser control ownership, tool execution with risk classification, policy enforcement, runtime probing, and update handling removed.
Browser Package Tests internal/browser/manager_test.go, internal/browser/service_test.go, internal/browser/safety_test.go, internal/browser/runtime_probe_test.go, internal/browser/updater_test.go	All browser package test suites deleted, including manager behavior validation, service RPC handling, safety/risk classification, runtime probing scenarios, and update verification.
Daemon Integration internal/loop/daemon.go, internal/loop/browser_rpc.go, internal/relay/conn.go	Daemon removes browser manager field, browser RPC socket server, runtime probing on connect, and browser capability flags in Hello messages; relay no longer advertises browser capabilities.
Session/Actor Integration internal/session/actor.go, internal/session/browser_tool_test.go	Actor removes browser grant/runtime context fields and setter methods (SetBrowserContext, SetBrowserGrant); task execution no longer propagates browser grant metadata; browser env injection test removed.
Pi Executor Integration internal/pi/executor.go, internal/pi/worker_key.go, internal/pi/worker_key_test.go	Executor removes browser-related Options fields and env setup; worker key drops browser identifiers; new test added for provider/skill-path defaults without browser coupling; old browser-grant test removed.
Pi Extension / TypeScript internal/pi/extension/browser-extension.ts, internal/pi/extension/browser-methods.ts, internal/pi/extension/browser-methods.generated.ts, internal/pi/extension/browser-tool.test.mjs, internal/pi/extension/browser-methods.generated.test.mjs, internal/pi/extension/index.ts	All browser extension wiring removed: gsd_browser tool definition, method/category registry, tool registration via registerBrowserExtension, browser grant context extraction; mergeClaudeCliTools signature simplified to remove browser grant parameter.
Skill Documentation & Packaging internal/pi/extension/gsd-browser-skill/SKILL.md, internal/pi/extension_package_test.go, scripts/package-pi-extension.sh	Browser skill documentation removed; extension package test updated to remove SKILL.md from required runtime files; packaging script simplified to exclude gsd-browser-skill directory.
CLI & Dependency cmd/pi_tui.go, go.mod	Pi TUI CLI flags (--browser-grant-id, --browser-id, --browser-session-id) and related piTUIFlags fields removed; protocol-go dependency updated from v0.36.0 to v0.37.0.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• Harden browser workbench control and guidance #139: Introduces and hardens the same browser manager, runtime probe, safety, service, types, and updater files/tests that this PR removes—direct inverse changes affecting identical code paths.
• feat: pi subagent extension with cloud-linked child sessions #108: Modifies Pi execution/extension plumbing (Options struct and extension wiring) that this PR also alters; could interact on session/executor configuration changes.
• Add ambient browser runtime bridge #135: Implements and wires the browser subsystem into the daemon loop and sessions—the exact subsystem this PR removes entirely.

Poem

🐰 The browser has hopped away, it's true,
All managers, safety, and grants bid adieu.
Extensions now simpler, no sockets to keep—
We've swept clean the warren, now audit can sleep! 🏠✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Remove browser automation from daemon' directly and clearly describes the main change: removing browser automation functionality from the daemon codebase.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/remove-gsd-browser

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}