Allow sourcing the acceptor_name from httpd #139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hostname the client uses to connect to apache is stored in the
request structure for modules to use.
This patch adds an option to specify that the acceptor name to be used
should be constructed on a per-request basis from this name.
This is simply achieved by specifying the literal string {HOSTNAME} to
the existing GssapiAcceptorName option insted of specifying a full
GSSAPI name.
Signed-off-by: Simo Sorce <simo@redhat.com>
Resolves gssapi#138
frozencemetery
approved these changes
May 2, 2017
Member
frozencemetery
left a comment
frozencemetery
left a comment
There was a problem hiding this comment.
Nit; otherwise looks good.
| @@ -0,0 +1,16 @@ | |||
| #!/usr/bin/python | |||
| # Copyright (C) 2015 - mod_auth_gssapi contributors, see COPYING for license. | |||
Member
There was a problem hiding this comment.
Year should probably be 2017?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hostname the client uses to connect to apache is stored in the
request structure for modules to use.
This patch adds an option to specify that the acceptor name to be used
should be constructed on a per-request basis from this name.
This is simply achieved by specifying the literal string {HOSTNAME} to
the existing GssapiAcceptorName option insted of specifying a full
GSSAPI name.
Signed-off-by: Simo Sorce simo@redhat.com
Resolves #138