Bog f25 sprint5 current #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Resolves #396 adds location in a new line in Map tab sidebar ### How to Test add a class and section with a location check location appears in Map tab --------- Co-authored-by: afazio1 <alexa.fazio04@gmail.com>
### Summary Resolves #404 Uses `daysToString` util on the `course.daysOfWeek` to correctly order days in the DaySelection component.
### Summary Resolves #383 Fixes overflow state for recurring events that are too small. excluded location on desktop and mobile ### How to Test Copy Uma's exact location here: <img width="299" height="207" alt="image" src="https://github.com/user-attachments/assets/83008c6f-ce84-4f14-8e23-d1af4a47a13e" /> make sure it doesn't overflow play around with other times in desktop and mobile to make sure it doesn't overflow.
### Summary Resolves #365 Add travel times to map view Co-authored-by: Uma Anand <uma2005anand@gmail.com>
### Summary Resolves #400 https://www.gt-scheduler.org/#/?courses=CS1332,MATH3012 ImportCoursesModal should pop up. Then, a user can confirm or deny importing the courses. This will **append** to `desiredCourses` and it will not add courses that cannot be found in `oscar.courses`. ### How to Test Append `?courses=CS1332,MATH3012` to the deploy preview url. https://www.gt-scheduler.org/pr-preview/pr-412/#/?courses=CS1332,MATH3012
### Summary Resolves #382 <!-- What does this PR change and why? Discuss any breaking changes. --> This PR makes the following 4 places show correct **section title** as **course name** for 8803 special topics courses: 1. SectionBlocks 2. CompareBlocks 3. Map list 4. Calendar export text ### Note: Merge Order Merge **this** PR after the [corresponding backend PR](gt-scheduler/crawler-v2#46). This PR includes a fallback, so merging out of order won’t break builds, but this order is preferred. ### Checklist - [x] fix: Special Topics courses show incorrect titles ### How to Test <!-- Describe how to test your code. --> ```zsh yarn start ``` 1. SectionBlocks <img width="334" height="216" alt="image" src="https://github.com/user-attachments/assets/d9cb531b-931a-4c6a-8cc7-c419b1538998" /> 2. CompareBlocks <img width="362" height="238" alt="image" src="https://github.com/user-attachments/assets/93b68480-eb4c-4b30-8cbb-d12509e14ead" /> 3. Map list <img width="273" height="164" alt="image" src="https://github.com/user-attachments/assets/559ad8dd-8df7-4209-87ad-79db0634ce27" /> 4. Calendar export text <img width="379" height="130" alt="image" src="https://github.com/user-attachments/assets/2526d38a-4d6e-4de4-8d71-d24bb506449d" /> --------- Co-authored-by: Uma Anand <63426041+uma-anand@users.noreply.github.com> Co-authored-by: Uma Anand <uma2005anand@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.