Skip to content
This repository was archived by the owner on Dec 12, 2023. It is now read-only.

Implement support for "ITU-R BT.2020" colorspace.#85

Merged
KelSolaar merged 1 commit intogtaylor:masterfrom
colour-science:feature/bt2020
Mar 12, 2018
Merged

Implement support for "ITU-R BT.2020" colorspace.#85
KelSolaar merged 1 commit intogtaylor:masterfrom
colour-science:feature/bt2020

Conversation

@KelSolaar
Copy link
Copy Markdown
Collaborator

@KelSolaar KelSolaar commented Mar 9, 2018

A few notes:

  • The conversion matrices and some of the transfer functions constants are computed with colour. I did not added a reference as there are no references atm in the codebase.
  • The way transfer functions are implemented as of now, i.e. in the RGB_to_XYZ and XYZ_to_RGB definitions is not very maintainable which is fine assuming only a few colorspaces are implemented.
  • The matrices of the various RGB colorspaces don't round trip properly, I would suggest keeping the NPM and have the inverse computed with np.linalg.inv.
  • I added a round-trip test for the RGB colorspace with transfer functions in mind, could be extended but it is a start.

Copy link
Copy Markdown
Owner

@gtaylor gtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about this color space, but the code looks reasonable.

@KelSolaar
Copy link
Copy Markdown
Collaborator Author

@gtaylor : The TLDR version is that it is basically the successor of sRGB/BT.709, it is becoming more and more important.

@KelSolaar KelSolaar merged commit 89862ba into gtaylor:master Mar 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants