Enable Python 3.7, 3.8 support#93
Conversation
|
Oh... I see this is unmaintained now (the docs didn't mention that). However, I see merge activity since then as well. Is this truly defunct? |
|
|
||
| def __init__(self, x, y, z, x_0, y_0, z_0, y_0_abs, k_1, k_2, sigma=300): | ||
| """ | ||
| r""" |
There was a problem hiding this comment.
Any reason for using raw strings over escaping the slashes?
There was a problem hiding this comment.
Specifically because I'm not sure how the documentation parser would deal with that, so I erred on the side of caution. I'd prefer to escape the slashes...
There was a problem hiding this comment.
sphinx.ext.autodoc imports modules to be documented (see warning at the very top of the page), so it's Python parser we're dealing with. Using escape slashes to fix SyntaxWarning should be safe here.
There was a problem hiding this comment.
A bit belated, but I've made the update as discussed.
(In both places it appeared.)
Nope! I'm trying to maintain the repo although I'm on a trip thus limited connection. |
MartyMacGyver
force-pushed
the
mff-upgrade-python
branch
2 times, most recently
from
3839ea7 to
f226cd3
Compare
MartyMacGyver
force-pushed
the
mff-upgrade-python
branch
from
f226cd3 to
59d3418
Compare
|
OK, I fixed the problem above, rebased, enabled 3.8 (not just 3.8-dev as it was previously). |
|
Thanks LGTM! |
3 participants
Small changes were made to support 3.8 escaping deprecations whilst maintaining backward compatibility.