feat: Start respecting MV response candidates#1744
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
gtema
force-pushed
the
response-candidates
branch
3 times, most recently
from
f8c5aaf to
5041537
Compare
Nova (in particular) has a strong deviations in responses across microversions. Sometimes it uses "oneOf" as a second level of response description. It causes cli/tui/(types) to actually fail in case it is used against a cloud with a "bad" microversion. This madness can only be handled with departing from the hope of having unified responses. Start building all possible response candidates (per microversion and also for the internal "oneOf"s where applicable (_a, _b, ... suffix). The cli in such cases tries to deserialize into different supported schemas in a row until something success (well, there is no other way to deal with it). In a near future the CLI (on the codegenerator) would start using the negotiated microversion to filter out response candidates that are definitely not matching.
gtema
force-pushed
the
response-candidates
branch
from
5041537 to
b383d14
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nova (in particular) has a strong deviations in responses across
microversions. Sometimes it uses "oneOf" as a second level of response
description. It causes cli/tui/(types) to actually fail in case it is
used against a cloud with a "bad" microversion. This madness can only be
handled with departing from the hope of having unified responses. Start
building all possible response candidates (per microversion and also for
the internal "oneOf"s where applicable (_a, _b, ... suffix). The cli in
such cases tries to deserialize into different supported schemas in a
row until something success (well, there is no other way to deal with
it). In a near future the CLI (on the codegenerator) would start using
the negotiated microversion to filter out response candidates that are
definitely not matching.