Skip to content

gir: Update and regenerate with impl Trait instead of named types #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2021
Merged

gir: Update and regenerate with impl Trait instead of named types #404

merged 1 commit into from
Sep 22, 2021

Conversation

@MarijnS95
Copy link
Contributor

@MarijnS95 MarijnS95 mentioned this pull request May 23, 2021
Merged
@bilelmoussaoui
Copy link
Member

Thanks! I will take care of handling the manual part in a separate MR

@bilelmoussaoui
Copy link
Member

The changes on this PR are not needed anymore as I regenreated few days ago. I'm going to go ahead and close this one

Thanks

@MarijnS95
Copy link
Contributor Author

@bilelmoussaoui The linked PR was split in two pieces, the part that refactors gir and drops where: has been merged, the original gtk-rs/gir#1153 is still up for debate (after the release) so this PR is still relevant for the diff (though I should probably rebase and force-push it).

Feel free to leave it closed for a while to decrease noise, but we should reopen it before a force-push (or GH detaches the PR from the branch).

@bilelmoussaoui
Copy link
Member

Sure, let me know when you want to update it. At worst I can take care of doing the update once the gir changes are in as it would require a bunch of manual changes well

@MarijnS95
Copy link
Contributor Author

@bilelmoussaoui Is it time to reopen this?

@sdroege
Copy link
Member

sdroege commented Sep 7, 2021

Seems like a good plan to get this in now, yes :)

@MarijnS95
Copy link
Contributor Author

@bilelmoussaoui The gir PR was merged, can you reopen this so that I can force-push?

@sdroege sdroege merged commit a12c212 into gtk-rs:master Sep 22, 2021
@MarijnS95 MarijnS95 deleted the impl-trait branch September 22, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdroege sdroege sdroege approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarijnS95 @bilelmoussaoui @sdroege