Skip to content

Add WhichVersionMatchesfunction implementation#796

Merged
kodiakhq[bot] merged 4 commits intomainfrom
ver-match
Apr 28, 2023
Merged

Add WhichVersionMatchesfunction implementation#796
kodiakhq[bot] merged 4 commits intomainfrom
ver-match

Conversation

@lumjjb
Copy link
Copy Markdown
Contributor

@lumjjb lumjjb commented Apr 28, 2023

lumjjb added 2 commits April 28, 2023 13:54
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb lumjjb marked this pull request as ready for review April 28, 2023 19:16
lumjjb added 2 commits April 28, 2023 15:19
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Copy link
Copy Markdown
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxp928 pxp928 requested a review from mihaimaruseac April 28, 2023 19:37
@kodiakhq kodiakhq bot merged commit e3add68 into main Apr 28, 2023
@mihaimaruseac mihaimaruseac deleted the ver-match branch April 28, 2023 20:01
mlieberman85 pushed a commit to mlieberman85/artifact-ff that referenced this pull request Jul 5, 2023
* add ParseVersionValue

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* implement WichVersionMatches

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* go mod tidy

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* remove debug messages

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

---------

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants