Skip to content

Add Certify bad query and re-org the query CLI#807

Merged
kodiakhq[bot] merged 5 commits intoguacsec:mainfrom
pxp928:certifyBad-query
May 2, 2023
Merged

Add Certify bad query and re-org the query CLI#807
kodiakhq[bot] merged 5 commits intoguacsec:mainfrom
pxp928:certifyBad-query

Conversation

@pxp928
Copy link
Copy Markdown
Collaborator

@pxp928 pxp928 commented May 2, 2023

Description of the PR

Add Certify bad query and re-org the query CLI. This CLI will output a list of certifyBads to choose from and output a visualization URL with all the dependent packages. Also, has support for artifacts and sources.

Last open item for #769

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 force-pushed the certifyBad-query branch 3 times, most recently from 0b619b6 to a997fd3 Compare May 2, 2023 14:25
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 force-pushed the certifyBad-query branch from a997fd3 to 27f17cc Compare May 2, 2023 14:57
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 marked this pull request as ready for review May 2, 2023 17:10
@pxp928 pxp928 requested a review from mihaimaruseac as a code owner May 2, 2023 17:10
@pxp928
Copy link
Copy Markdown
Collaborator Author

pxp928 commented May 2, 2023

cc @lumjjb

Comment thread cmd/guacone/cmd/queryBad.go
Comment thread cmd/guacone/cmd/queryVulnerability.go Outdated
Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Copy Markdown
Member

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw a typo with the opts, LGTM

Comment thread cmd/guacone/cmd/queryBad.go Outdated
Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq Bot merged commit 649c204 into guacsec:main May 2, 2023
@pxp928 pxp928 deleted the certifyBad-query branch May 2, 2023 18:52
mlieberman85 pushed a commit to mlieberman85/artifact-ff that referenced this pull request Jul 5, 2023
* add certifyBad query CLI

Signed-off-by: pxp928 <parth.psu@gmail.com>

* move query into subcommands

Signed-off-by: pxp928 <parth.psu@gmail.com>

* rename files

Signed-off-by: pxp928 <parth.psu@gmail.com>

* fix bug in source, move purl to be postional arg in vuln query

Signed-off-by: pxp928 <parth.psu@gmail.com>

* fixed typo

Signed-off-by: pxp928 <parth.psu@gmail.com>

---------

Signed-off-by: pxp928 <parth.psu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants