Skip to content

fix(cargo): propagate timeout error with actionable message#429

Merged
ruromero merged 1 commit intoguacsec:mainfrom
ruromero:TC-4165
Apr 21, 2026
Merged

fix(cargo): propagate timeout error with actionable message#429
ruromero merged 1 commit intoguacsec:mainfrom
ruromero:TC-4165

Conversation

@ruromero
Copy link
Copy Markdown
Collaborator

@ruromero ruromero commented Apr 20, 2026

Summary

  • Propagates timeout and I/O errors as RuntimeException instead of silently logging them, ensuring callers are notified of failures
  • Adds system property hint (-Dtrustify.cargo.timeout.seconds=N) to timeout error message for easy adjustment

Implements TC-4165

Test plan

  • All 29 existing Cargo tests pass (CargoProviderTest, CargoSbomTest)
  • Timeout error message includes system property hint
  • Errors propagate correctly through addDependencies()createSbom() call chain
  • CI integration tests pass on cargo-stable scenario

🤖 Generated with Claude Code

@ruromero ruromero requested a review from a-oren April 20, 2026 18:40
- Propagate timeout and I/O errors as RuntimeException instead of silently logging
- Include system property hint (-Dtrustify.cargo.timeout.seconds=N) in timeout error message

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ruromero ruromero changed the title fix(cargo): propagate timeout error and increase default to 120s fix(cargo): propagate timeout error with actionable message Apr 20, 2026
@ruromero
Copy link
Copy Markdown
Collaborator Author

Increased cargo timeout in trustification/exhort-integration-tests#34

@ruromero ruromero enabled auto-merge (squash) April 20, 2026 20:49
@ruromero ruromero merged commit a4069a3 into guacsec:main Apr 21, 2026
74 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants