Skip to content

fix: set cwd for mvn invocations to manifest dir #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

fix: set cwd for mvn invocations to manifest dir #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/providers/base_java.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ export default class Base_Java {
* Exists for stubbing in tests.
* @param bin - the command to be invoked
* @param args - the args to pass to the binary
* @param {import('child_process').ExecFileOptionsWithStringEncoding} [opts={}]
* @protected
*/
_invokeCommand(bin, args, opts={}) { return invokeCommand(bin, args, opts) }
Expand All @@ -138,14 +139,15 @@ export default class Base_Java {
* @returns string
*/
selectToolBinary(manifestPath, opts) {
const manifestDir = path.dirname(manifestPath)
const toolPath = getCustomPath(this.globalBinary, opts)

const useWrapper = getWrapperPreference(toolPath, opts)
if (useWrapper) {
const wrapper = this.traverseForWrapper(manifestPath)
if (wrapper !== undefined) {
try {
this._invokeCommand(wrapper, ['--version'])
this._invokeCommand(wrapper, ['--version'], {cwd: manifestDir})
} catch (error) {
throw new Error(`failed to check for ${this.localWrapper}`, {cause: error})
}
Expand All @@ -154,7 +156,7 @@ export default class Base_Java {
}
// verify tool is accessible, if wrapper was not requested or not found
try {
this._invokeCommand(toolPath, ['--version'])
this._invokeCommand(toolPath, ['--version'], {cwd: manifestDir})
} catch (error) {
if (error.code === 'ENOENT') {
throw new Error((useWrapper ? `${this.localWrapper} not found and ` : '') + `${this.globalBinary === 'mvn' ? 'maven' : 'gradle'} not found at ${toolPath}`)
Expand Down
14 changes: 7 additions & 7 deletions src/providers/java_maven.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,12 @@ export default class Java_maven extends Base_java {
* @private
*/
#createSbomStackAnalysis(manifest, opts = {}) {
const manifestDir = path.dirname(manifest)
const mvn = this.selectToolBinary(manifest, opts)

// clean maven target
try {
this._invokeCommand(mvn, ['-q', 'clean', '-f', manifest])
this._invokeCommand(mvn, ['-q', 'clean'], {cwd: manifestDir})
} catch (error) {
throw new Error(`failed to clean maven target`, {cause: error})
}
Expand All @@ -89,7 +90,7 @@ export default class Java_maven extends Base_java {
let tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'exhort_'))
let tmpDepTree = path.join(tmpDir, 'mvn_deptree.txt')
// build initial command (dot outputType is not available for verbose mode)
let depTreeCmdArgs = ['-q', 'org.apache.maven.plugins:maven-dependency-plugin:3.6.0:tree', '-Dverbose', '-DoutputType=text', `-DoutputFile=${tmpDepTree}`, '-f', manifest]
let depTreeCmdArgs = ['-q', 'org.apache.maven.plugins:maven-dependency-plugin:3.6.0:tree', '-Dverbose', '-DoutputType=text', `-DoutputFile=${tmpDepTree}`]
// exclude ignored dependencies, exclude format is groupId:artifactId:scope:version.
// version and scope are marked as '*' if not specified (we do not use scope yet)
let ignoredDeps = new Array()
Expand All @@ -101,7 +102,7 @@ export default class Java_maven extends Base_java {
})
// execute dependency tree command
try {
this._invokeCommand(mvn, depTreeCmdArgs)
this._invokeCommand(mvn, depTreeCmdArgs, {cwd: manifestDir})
} catch (error) {
throw new Error(`failed creating maven dependency tree`, {cause: error})
}
Expand Down Expand Up @@ -144,22 +145,21 @@ export default class Java_maven extends Base_java {
const mvn = this.selectToolBinary(manifestPath, opts)

const tmpEffectivePom = path.resolve(path.join(path.dirname(manifestPath), 'effective-pom.xml'))
const targetPom = manifestPath

// create effective pom and save to temp file
try {
this._invokeCommand(mvn, ['-q', 'help:effective-pom', `-Doutput=${tmpEffectivePom}`, '-f', targetPom])
this._invokeCommand(mvn, ['-q', 'help:effective-pom', `-Doutput=${tmpEffectivePom}`], {cwd: path.dirname(manifestPath)})
} catch (error) {
throw new Error(`failed creating maven effective pom`, {cause: error})
}
// iterate over all dependencies in original pom and collect all ignored ones
let ignored = this.#getDependencies(targetPom).filter(d => d.ignore)
let ignored = this.#getDependencies(manifestPath).filter(d => d.ignore)
// iterate over all dependencies and create a package for every non-ignored one
/** @type [Dependency] */
let dependencies = this.#getDependencies(tmpEffectivePom)
.filter(d => !(this.#dependencyIn(d, ignored)) && !(this.#dependencyInExcludingVersion(d, ignored)))
let sbom = new Sbom();
let rootDependency = this.#getRootFromPom(tmpEffectivePom, targetPom);
let rootDependency = this.#getRootFromPom(tmpEffectivePom, manifestPath);
let purlRoot = this.toPurl(rootDependency.groupId, rootDependency.artifactId, rootDependency.version)
sbom.addRoot(purlRoot)
dependencies.forEach(dep => {
Expand Down
Loading