fix: use & pass down opts for getCustom in imageAnalysis #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
force-pushed
the
nsc/image-analysis-opts
branch
from
622f50d to
89eaab1
Compare
ruromero
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
image analysis was still using
process.envin a lot of places such as for using EXHORT_IMAGE_PLATFORM. This is a holdover from when this was still the externally executed JAR file, where reading from env was the correct approach. This PR updates this translated code to usegetCustomlike other parts of the library, and passingoptsdown correctly to all the relevant sectionsRelated issues (if any):
Checklist