fix: maven deps parsing bugs #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix Jira Ticket: https://issues.redhat.com/browse/TC-766 fix Jira Ticket https://issues.redhat.com/browse/TC-797 Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix parsing of dependency from dependency tree text format, taking into account also maven artifacts with classifier ( aka version suffix)
Use a single simplified REGEX with global regex flag (/g) in order to parse all dependencies from dependency tree correctly and efficiently.
omit redundant characters from REGEX used to choose the right resolved version for artifact that had conflicts - this caused all the discrepancies between exhort-java-api and exhort-javascript-api for maven stack analysis.
Fixing broken Integration tests.
Checklist
Additional information
the above 3 fixes closing the following tickets:
https://issues.redhat.com/browse/TC-766
https://issues.redhat.com/browse/TC-797