Skip to content

fix: allow missing root component purl #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

fix: allow missing root component purl #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/com/redhat/exhort/integration/sbom/cyclonedx/CycloneDxParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ public DependencyTree buildTree(InputStream input) {
} else if (componentPurls.containsKey(rootComponent.get().getBomRef())) {
rootRef = componentPurls.get(rootComponent.get().getBomRef());
}
if (rootRef == null) {
rootRef =
new PackageRef(
String.format(
"pkg:generic/%s@%s",
rootComponent.get().getName(), rootComponent.get().getVersion()));
}
}
var tree = treeBuilder.dependencies(buildDependencies(bom, componentPurls, rootRef)).build();
return tree;
Expand Down
11 changes: 11 additions & 0 deletions src/test/java/com/redhat/exhort/integration/backend/sbom/cyclonedx/CycloneDxParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,17 @@ void testParseInvalidSbom() throws IOException {
}
}

@Test
void testParseSbomWithNoRootPurl() throws IOException {
CycloneDxParser parser = new CycloneDxParser();
try (InputStream input =
getClass().getResourceAsStream(TEST_RESOURCES_PATH + "no-root-purl-sbom.json")) {
assertNotNull(input, "Test resource not found");
var tree = parser.buildTree(input);
assertEquals(1, tree.dependencies().size());
}
}

@ParameterizedTest
@ValueSource(strings = {"1.0", "1.1", "1.2", "1.3", "1.4", "1.5", "1.6"})
void testSupportedVersions(String version) throws IOException {
Expand Down
44 changes: 44 additions & 0 deletions src/test/resources/cyclonedx/no-root-purl-sbom.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{
"bomFormat": "CycloneDX",
"specVersion": "1.5",
"version": 1,
"metadata": {
"timestamp": "2025-07-22T12:00:00Z",
"tools": [
{
"vendor": "OpenAI",
"name": "ChatGPT-SBOM-Generator",
"version": "1.0"
}
],
"component": {
"type": "application",
"name": "example-app",
"version": "1.0.0",
"bom-ref": "pkg:generic/example-app@1.0.0"
}
},
"components": [
{
"type": "library",
"name": "commons-compress",
"version": "1.21.0.redhat-00001",
"publisher": "Red Hat, Inc.",
"group": "org.apache.commons",
"purl": "pkg:maven/org.apache.commons/commons-compress@1.21.0.redhat-00001?repository_url=https://maven.repository.redhat.com/ga/&type=jar",
"bom-ref": "pkg:maven/org.apache.commons/commons-compress@1.21.0.redhat-00001?repository_url=https://maven.repository.redhat.com/ga/&type=jar"
}
],
"dependencies": [
{
"ref": "pkg:generic/example-app@1.0.0",
"dependsOn": [
"pkg:maven/org.apache.commons/commons-compress@1.21.0.redhat-00001?repository_url=https://maven.repository.redhat.com/ga/&type=jar"
]
},
{
"ref": "pkg:maven/org.apache.commons/commons-compress@1.21.0.redhat-00001?repository_url=https://maven.repository.redhat.com/ga/&type=jar",
"dependsOn": []
}
]
}