Conversation
bryophyta
commented
Oct 30, 2025
| } | ||
|
|
||
| struct IconikData { | ||
| 1: optional string workingGroupId |
Contributor
Author
There was a problem hiding this comment.
these four fields comprise the core data that we need to identify an Iconik project
Ignore IDE files
7a829d3 to
0934148
Compare
gu-scala-library-release Bot
added a commit
that referenced
this pull request
Oct 31, 2025
…yophyta bryophyta published release version 8.0.0-PREVIEW.pficonik-data.2025-10-31T0908.09341485 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 8.0.0-PREVIEW.pficonik-data.2025-10-31T0908.09341485 Release-Initiated-By: https://github.com/bryophyta Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/18967916435 Release-Notes: #193
Contributor
|
@bryophyta has published a preview version of this PR with release workflow run #39, based on commit 0934148: 8.0.0-PREVIEW.pficonik-data.2025-10-31T0908.09341485 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the pf/iconik-data branch, or use the GitHub CLI command: gh workflow run release.yml --ref pf/iconik-data Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
lindseydew
approved these changes
Nov 11, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
IconikDatastruct for the media atom definition. Iconik is the system that's going to replace Pluto, and the new struct is modelled after the one for PlutoData.Tested in Media Atom Maker, via guardian/atom-maker#114