Skip to content

Conversation

@mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Jan 5, 2024

What does this change?

Remove PR deployments option.

Why?

They are almost never used! The limits of ngrok mean that in practice this is a lot less reliable and useful that deploying to CODE.

Introduced in:

@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Jan 5, 2024
@mxdvl mxdvl requested a review from a team as a code owner January 5, 2024 15:00
@github-actions
Copy link

github-actions bot commented Jan 5, 2024

Size Change: 0 B

Total Size: 741 kB

ℹ️ View Unchanged
Filename Size
dotcom-rendering/dist/1028.web.********************.js 783 B
dotcom-rendering/dist/1079.web.********************.js 5.05 kB
dotcom-rendering/dist/11.web.********************.js 5.18 kB
dotcom-rendering/dist/115.web.********************.js 3.68 kB
dotcom-rendering/dist/1170.web.********************.js 3.6 kB
dotcom-rendering/dist/1285.web.********************.js 921 B
dotcom-rendering/dist/1309.web.********************.js 637 B
dotcom-rendering/dist/1378.web.********************.js 503 B
dotcom-rendering/dist/1623.web.********************.js 847 B
dotcom-rendering/dist/2027.web.********************.js 3.08 kB
dotcom-rendering/dist/2030.web.********************.js 491 B
dotcom-rendering/dist/2118.web.********************.js 775 B
dotcom-rendering/dist/2138.web.********************.js 2.59 kB
dotcom-rendering/dist/2416.web.********************.js 775 B
dotcom-rendering/dist/2710.web.********************.js 999 B
dotcom-rendering/dist/2903.web.********************.js 884 B
dotcom-rendering/dist/2993.web.********************.js 636 B
dotcom-rendering/dist/3032.web.********************.js 3.15 kB
dotcom-rendering/dist/307.web.********************.js 13.2 kB
dotcom-rendering/dist/3316.web.********************.js 3.48 kB
dotcom-rendering/dist/3664.web.********************.js 5.5 kB
dotcom-rendering/dist/3743.web.********************.js 900 B
dotcom-rendering/dist/3849.web.********************.js 3.33 kB
dotcom-rendering/dist/3958.web.********************.js 39.9 kB
dotcom-rendering/dist/3999.web.********************.js 744 B
dotcom-rendering/dist/408.web.********************.js 3.38 kB
dotcom-rendering/dist/4215.web.********************.js 404 B
dotcom-rendering/dist/4298.web.********************.js 8.12 kB
dotcom-rendering/dist/4355.web.********************.js 710 B
dotcom-rendering/dist/4464.web.********************.js 3.79 kB
dotcom-rendering/dist/4567.web.********************.js 819 B
dotcom-rendering/dist/4578.web.********************.js 3.5 kB
dotcom-rendering/dist/4698.web.********************.js 2.47 kB
dotcom-rendering/dist/4946.web.********************.js 718 B
dotcom-rendering/dist/4950.web.********************.js 664 B
dotcom-rendering/dist/512.web.********************.js 819 B
dotcom-rendering/dist/5165.web.********************.js 742 B
dotcom-rendering/dist/5242.web.********************.js 524 B
dotcom-rendering/dist/533.web.********************.js 916 B
dotcom-rendering/dist/5481.web.********************.js 5.2 kB
dotcom-rendering/dist/5840.web.********************.js 915 B
dotcom-rendering/dist/5927.web.********************.js 819 B
dotcom-rendering/dist/5996.web.********************.js 797 B
dotcom-rendering/dist/6388.web.********************.js 5.75 kB
dotcom-rendering/dist/651.web.********************.js 847 B
dotcom-rendering/dist/6541.web.********************.js 909 B
dotcom-rendering/dist/6643.web.********************.js 950 B
dotcom-rendering/dist/6756.web.********************.js 519 B
dotcom-rendering/dist/6763.web.********************.js 589 B
dotcom-rendering/dist/6784.web.********************.js 739 B
dotcom-rendering/dist/6802.web.********************.js 990 B
dotcom-rendering/dist/7002.web.********************.js 871 B
dotcom-rendering/dist/7179.web.********************.js 2.51 kB
dotcom-rendering/dist/7444.web.********************.js 781 B
dotcom-rendering/dist/7496.web.********************.js 6.39 kB
dotcom-rendering/dist/7666.web.********************.js 2.75 kB
dotcom-rendering/dist/7726.web.********************.js 955 B
dotcom-rendering/dist/7860.web.********************.js 675 B
dotcom-rendering/dist/7880.web.********************.js 9.97 kB
dotcom-rendering/dist/8003.web.********************.js 2.85 kB
dotcom-rendering/dist/8060.web.********************.js 578 B
dotcom-rendering/dist/8288.web.********************.js 23 kB
dotcom-rendering/dist/8320.web.********************.js 796 B
dotcom-rendering/dist/8388.web.********************.js 612 B
dotcom-rendering/dist/8442.web.********************.js 3.79 kB
dotcom-rendering/dist/8562.web.********************.js 998 B
dotcom-rendering/dist/8795.web.********************.js 16.2 kB
dotcom-rendering/dist/8860.web.********************.js 2.49 kB
dotcom-rendering/dist/8995.web.********************.js 782 B
dotcom-rendering/dist/9031.web.********************.js 8.91 kB
dotcom-rendering/dist/9033.web.********************.js 883 B
dotcom-rendering/dist/9045.web.********************.js 715 B
dotcom-rendering/dist/9106.web.********************.js 2.97 kB
dotcom-rendering/dist/9145.web.********************.js 4.23 kB
dotcom-rendering/dist/9206.web.********************.js 4.71 kB
dotcom-rendering/dist/9458.web.********************.js 5.1 kB
dotcom-rendering/dist/9479.web.********************.js 2.91 kB
dotcom-rendering/dist/9591.web.********************.js 1.84 kB
dotcom-rendering/dist/9721.web.********************.js 646 B
dotcom-rendering/dist/9856.web.********************.js 5.75 kB
dotcom-rendering/dist/9893.web.********************.js 3.26 kB
dotcom-rendering/dist/9895.web.********************.js 5.07 kB
dotcom-rendering/dist/991.web.********************.js 3.15 kB
dotcom-rendering/dist/AdPortals-importable.web.********************.js 3.65 kB
dotcom-rendering/dist/AlreadyVisited-importable.web.********************.js 415 B
dotcom-rendering/dist/AppEmailSignUp-importable.web.********************.js 8.16 kB
dotcom-rendering/dist/AppsEpic-importable.web.********************.js 4.02 kB
dotcom-rendering/dist/AppsFooter-importable.web.********************.js 3.57 kB
dotcom-rendering/dist/AppsLightboxImage-importable.web.********************.js 2.96 kB
dotcom-rendering/dist/AppsLightboxImageStore-importable.web.********************.js 2.42 kB
dotcom-rendering/dist/AudioAtomWrapper-importable.web.********************.js 3.58 kB
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.********************.js 4.61 kB
dotcom-rendering/dist/Branding-importable.web.********************.js 2.52 kB
dotcom-rendering/dist/braze-web-sdk-core.web.********************.js 36.9 kB
dotcom-rendering/dist/BrazeMessaging-importable.web.********************.js 5.26 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.web.********************.js 6.76 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.********************.js 5.77 kB
dotcom-rendering/dist/CardCommentCount-importable.web.********************.js 4.39 kB
dotcom-rendering/dist/Carousel-importable.web.********************.js 7.78 kB
dotcom-rendering/dist/CarouselForNewsletters-importable.web.********************.js 5.66 kB
dotcom-rendering/dist/ChartAtom-importable.web.********************.js 537 B
dotcom-rendering/dist/CommentCount-importable.web.********************.js 3.21 kB
dotcom-rendering/dist/DiscussionContainer-importable.web.********************.js 23.4 kB
dotcom-rendering/dist/DiscussionMeta-importable.web.********************.js 3.74 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.web.********************.js 3.57 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.web.********************.js 4.1 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.web.********************.js 1.96 kB
dotcom-rendering/dist/FetchOnwardsData-importable.web.********************.js 2.51 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.********************.js 3.32 kB
dotcom-rendering/dist/FocusStyles-importable.web.********************.js 608 B
dotcom-rendering/dist/FollowWrapper-importable.web.********************.js 3.08 kB
dotcom-rendering/dist/FooterLabel-importable.web.********************.js 336 B
dotcom-rendering/dist/frameworks.web.********************.js 20.7 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.web.********************.js 3.72 kB
dotcom-rendering/dist/GetMatchNav-importable.web.********************.js 9.64 kB
dotcom-rendering/dist/GetMatchStats-importable.web.********************.js 1.74 kB
dotcom-rendering/dist/GetMatchTabs-importable.web.********************.js 2.75 kB
dotcom-rendering/dist/guardian-braze-components-banner.web.********************.js 14.7 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.web.********************.js 9.29 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.web.********************.js 777 B
dotcom-rendering/dist/HeaderTopBar-importable.web.********************.js 10.8 kB
dotcom-rendering/dist/index.web.********************.js 45.9 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.web.********************.js 3.66 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.web.********************.js 6.07 kB
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.********************.js 4.63 kB
dotcom-rendering/dist/InteractiveSupportButton-importable.web.********************.js 3.88 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.web.********************.js 4.14 kB
dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.********************.js 3.54 kB
dotcom-rendering/dist/LatestLinks-importable.web.********************.js 1.2 kB
dotcom-rendering/dist/LightboxHash-importable.web.********************.js 429 B
dotcom-rendering/dist/LightboxJavascript-importable.web.********************.js 4.39 kB
dotcom-rendering/dist/LiveBlogEpic-importable.web.********************.js 3.95 kB
dotcom-rendering/dist/Liveness-importable.web.********************.js 4.9 kB
dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.********************.js 5.03 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.********************.js 5.62 kB
dotcom-rendering/dist/Metrics-importable.web.********************.js 2.28 kB
dotcom-rendering/dist/MostViewedFooter-importable.web.********************.js 5.19 kB
dotcom-rendering/dist/MostViewedFooterData-importable.web.********************.js 3.35 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.web.********************.js 3.88 kB
dotcom-rendering/dist/OnwardsUpper-importable.web.********************.js 4.16 kB
dotcom-rendering/dist/PersonalityQuizAtom-importable.web.********************.js 3.66 kB
dotcom-rendering/dist/ProfileAtom-importable.web.********************.js 539 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.web.********************.js 797 B
dotcom-rendering/dist/PulsingDot-importable.web.********************.js 746 B
dotcom-rendering/dist/QandaAtom-importable.web.********************.js 534 B
dotcom-rendering/dist/ReaderRevenueDev-importable.web.********************.js 466 B
dotcom-rendering/dist/readerRevenueDevUtils.web.********************.js 2.37 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.web.********************.js 6.06 kB
dotcom-rendering/dist/RelativeTime-importable.web.********************.js 1.92 kB
dotcom-rendering/dist/RichLinkComponent-importable.web.********************.js 6.19 kB
dotcom-rendering/dist/SecureSignupIframe-importable.web.********************.js 4.92 kB
dotcom-rendering/dist/SendAMessage-importable.web.********************.js 4.39 kB
dotcom-rendering/dist/SendTargetingParams-importable.web.********************.js 2.1 kB
dotcom-rendering/dist/sentry.web.********************.js 767 B
dotcom-rendering/dist/SetABTests-importable.web.********************.js 3.5 kB
dotcom-rendering/dist/SetAdTargeting-importable.web.********************.js 480 B
dotcom-rendering/dist/shimport.web.********************.js 2.78 kB
dotcom-rendering/dist/ShowHideContainers-importable.web.********************.js 643 B
dotcom-rendering/dist/ShowMore-importable.web.********************.js 5.69 kB
dotcom-rendering/dist/SignInGateMain.web.********************.js 3.89 kB
dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.********************.js 4.99 kB
dotcom-rendering/dist/SignInGateSelector-importable.web.********************.js 5.59 kB
dotcom-rendering/dist/SlotBodyEnd-importable.web.********************.js 6.77 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.web.********************.js 5.47 kB
dotcom-rendering/dist/StickyBottomBanner-importable.web.********************.js 5.53 kB
dotcom-rendering/dist/SubNav-importable.web.********************.js 2.21 kB
dotcom-rendering/dist/SupportTheG-importable.web.********************.js 6.18 kB
dotcom-rendering/dist/TableOfContents-importable.web.********************.js 3.1 kB
dotcom-rendering/dist/TimelineAtom-importable.web.********************.js 1.24 kB
dotcom-rendering/dist/TweetBlockComponent-importable.web.********************.js 1.02 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.********************.js 3.67 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.********************.js 5.63 kB
dotcom-rendering/dist/VineBlockComponent-importable.web.********************.js 3.5 kB
dotcom-rendering/dist/WeatherWrapper-importable.web.********************.js 5.42 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.web.********************.js 4 kB

compressed-size-action

Copy link
Contributor

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have personally never used this in the 6 months I've been on the team 😶‍🌫️

@mxdvl mxdvl merged commit 0c185eb into main Jan 5, 2024
@mxdvl mxdvl deleted the mxdvl/remove-pr-deployments branch January 5, 2024 15:53
@mxdvl mxdvl changed the title feat: remove unused PR deployments Remove unused PR deployments Jan 5, 2024
@prout-bot
Copy link

Seen on PROD (merged by @mxdvl 8 minutes and 57 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_chromatic Runs chromatic when label is applied Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants