-
Notifications
You must be signed in to change notification settings - Fork 30
Swap article-rendering instance class to C7G
#10780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 760 kB ℹ️ View Unchanged
|
5fbe471 to
3300024
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the |
ioannakok
approved these changes
Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
instanceTypeas a CDK prop instead of justinstanceSize, allowing us to have more control over the class of instance per app as well as just the size.C7Gmedium for thearticle-renderingappWhy?
Burstable instances want low CPU usage for most of the time, allowing for short periods of high traffic before returning to baseline. Despite upping to a medium size and increasing the number of instances running, the CPU usage does not fall within the range we want. We would need to use a T4G large instance in order to see benefits from the burstable instance type. Since this is more expensive than using a fixed instance type, it's worth exploring whether our app would be better suited to a fixed type.