Include Labs redesign switch in Front decisions #14512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
force-pushed
the
cemms1/prep-for-labs-redesign
branch
from
510577a to
425cd60
Compare
cemms1
commented
Sep 17, 2025
| title, | ||
| showSectionColours, | ||
| ) | ||
| {!isLabs && !showLabsRedesign && ( |
Contributor
Author
There was a problem hiding this comment.
Only including this now as a way to "use" the newly introduced props to avoid linting warnings
cemms1
commented
Sep 17, 2025
| if (collection.containerPalette === 'Branded') { | ||
| if ( | ||
| collection.containerPalette === 'Branded' && | ||
| !showLabsRedesign |
Contributor
Author
There was a problem hiding this comment.
We won't render the container redesign here, we'll do it in FrontSection instead. So this will only run if the switch is off
cemms1
force-pushed
the
cemms1/prep-for-labs-redesign
branch
from
425cd60 to
f0a9f33
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Prepare for Labs redesign work by including the switch added in frontend
There should be no visual changes in this PR
Why?
To allow us to develop safely and incrementally while we work on implementing the new designs