Migrate AB Testing scripts to node #14837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakeii
force-pushed
the
jlk/ab-testing-node-migration
branch
from
13f1b54 to
4ffb79c
Compare
Jakeii
force-pushed
the
jlk/ab-testing-node-migration
branch
from
4ffb79c to
8b25cc5
Compare
Jakeii
commented
Nov 13, 2025
| riff-raff: | ||
| name: AB testing Riffraff upload | ||
| runs-on: ubuntu-latest | ||
| needs: build-ui |
Member
Author
There was a problem hiding this comment.
not sure how this was working at all without this🤔
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Jakeii
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Migrate the
ab-testingcode from Deno to NodeWhy?
As much as we like Deno, soon we'll be adding some CDK and moving the deployment of ab tests to the fastly edge dictionary to a lambda. We'd like to share the code as much as possible between the CI scripts and the lambda so migrating them to node is the best option for this.
Node now supports running typescript files without a compilation step, which makes things a bit easier!