Remove old sign-in gate tests #14930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We have several old AB tests relating to the sign-in gate which are no longer relevant.
This PR removes them.
All gates are now served by support-dotcom-components.
The only
ABTestthat remains is theNoAuxiaSignInGatetest, which we use to exclude a portion of the audience from Auxia messaging.The switches are being removed from Frontend here: guardian/frontend#28424
I'll update DCR to use the new feature switch in a follow up change.
Why?
This is unused code, and we can remove these tests/switches from the Frontend repo as well.
Note - there is more legacy sign-in gate code to be cleaned up in this repo, but that's for another day.
Testing
Tested by ensuring gates still show on articles.