Put the Labs Redesign live #15007
Merged
Put the Labs Redesign live #15007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
force-pushed
the
cemms1/put-labs-redesign-live
branch
3 times, most recently
from
f43c5a3 to
71f45fd
Compare
github-actions
bot
removed
the
run_chromatic
cemms1
force-pushed
the
cemms1/put-labs-redesign-live
branch
from
7895451 to
847b120
Compare
github-actions
bot
removed
the
run_chromatic
cemms1
force-pushed
the
cemms1/put-labs-redesign-live
branch
from
847b120 to
968a684
Compare
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the
showLabsRedesignlogic and swaps all logic over to the new, redesigned version of labs cards and containers.The previous components which are no longer in use have also been removed:
LabsSectionCardBrandingAn optional prop for the
BrandingLogocomponentdataTestIdhas been added to allow the Playwright tests to continue to easily distinguish between logos in onward content cards and logos in the page meta.The 0% AB test and feature switch will be taken down in frontend guardian/frontend#28471
Why?
The feature switch for the labs redesign work was switched on in PROD in mid November. It's been live for a couple of weeks now so we're ready to make this change permanent.
This means getting rid of the 0% AB test and feature switch used in testing and swapping over to the new code