Add new dispatch event for when no banner is rendered#15053
Open
dskamiotis wants to merge 6 commits intomainfrom
Open
Add new dispatch event for when no banner is rendered#15053dskamiotis wants to merge 6 commits intomainfrom
dskamiotis wants to merge 6 commits intomainfrom
Conversation
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
dskamiotis
force-pushed
the
ds/add-rr-banner-close-event
branch
from
b9fb250 to
e2d2fdc
Compare
dskamiotis
force-pushed
the
ds/add-rr-banner-close-event
branch
from
e2d2fdc to
73fdc09
Compare
GHaberis
approved these changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Nice, I can see introducing hasPickMessageCompleted provides precise control over when to dispatch 'banner:none' and ensures the event only fires once banner selection is truly complete so there's no premature dispatch during initial rendering, looks good 👍
GHaberis
approved these changes
Jan 9, 2026
cemms1
approved these changes
Jan 12, 2026
dotcom-rendering/src/components/StickyBottomBanner.importable.tsx
Outdated
Show resolved
Hide resolved
cemms1
reviewed
Jan 12, 2026
dotcom-rendering/src/components/StickyBottomBanner.importable.tsx
Outdated
Show resolved
Hide resolved
cemms1
reviewed
Jan 13, 2026
dotcom-rendering/src/components/StickyBottomBanner.importable.tsx
Outdated
Show resolved
Hide resolved
dskamiotis
force-pushed
the
ds/add-rr-banner-close-event
branch
from
cb1c185 to
334324d
Compare
…anner is rendered - adding logic inside of useEffect before returning to prevent lint error
…- wait for pickMessage to complete first before dispatching banner:none
dskamiotis
force-pushed
the
ds/add-rr-banner-close-event
branch
from
334324d to
bf8b353
Compare
github-actions
bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds custom event dispatching to the
StickyBottomBannercomponent to signal banner state to the commercial bundle:banner:none- Fired when no banner is selected to displayThese events are dispatched via
document.dispatchEvent()and can be listened to by the commercial bundle to control when mobile sticky ads should show.Why?
The commercial team needs to coordinate mobile sticky ad placement with reader revenue banners. Mobile sticky ads should only show when:
banner:close)banner:none)This prevents ads from showing up in the DOM and going against google ad policy
Related to guardian/commercial#2351 which implements the listening logic.