Conversation
domlander
added
run_chromatic
domlander
force-pushed
the
doml/onward-journeys-test
branch
from
3eae906 to
22e226c
Compare
domlander
force-pushed
the
doml/onward-journeys-test
branch
from
22e226c to
47ab363
Compare
domlander
force-pushed
the
doml/onward-journeys-test
branch
from
47ab363 to
faa6ec0
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
force-pushed
the
doml/onward-journeys-test
branch
from
faa6ec0 to
30115de
Compare
domlander
force-pushed
the
doml/onward-journeys-test
branch
from
30115de to
9c85604
Compare
abeddow91
reviewed
Jan 13, 2026
Comment on lines
+678
to
+683
| if ( | ||
| isMoreGalleriesOnwardContent || | ||
| // This is untidy. If we implement the gallery-style redesign for onwards content | ||
| // in all articles, we can refactor how we determine gap sizes for onwards cards. | ||
| isInOnwardsAbTestVariantStandardCard | ||
| ) { |
abeddow91
reviewed
Jan 13, 2026
Comment on lines
-56
to
-59
|
|
||
| ${from.leftCol} { | ||
| ${grid.between('centre-column-start', 'right-column-end')} | ||
| } |
abeddow91
reviewed
Jan 13, 2026
Comment on lines
+328
to
+329
| const isGalleryArticle = format.design === ArticleDesign.Gallery; | ||
|
|
Contributor
There was a problem hiding this comment.
This makes the below more clearer to parse, thanks
abeddow91
reviewed
Jan 13, 2026
Comment on lines
+192
to
+196
| * We are running an AB test to use the More Galleries style of onwards content on all articles. | ||
| * If the test is successful, the plan is that this component will be removed and MoreGalleries.tsx will | ||
| * be generalised so that is can be used for onwards content across all articles. If the | ||
| * test is not successful, this component will be removed. | ||
| */ |
Contributor
There was a problem hiding this comment.
Thanks for the explainer.
abeddow91
reviewed
Jan 13, 2026
Comment on lines
+122
to
+143
| const convertFETrailToDcrTrail = ( | ||
| trails: FETrailType[], | ||
| discussionApiUrl: string, | ||
| ): DCRFrontCard[] => | ||
| trails.map((trail) => ({ | ||
| dataLinkName: 'onwards-content-card', | ||
| discussionId: trail.discussion?.discussionId, | ||
| discussionApiUrl, | ||
| format: decideFormat(trail.format), | ||
| headline: trail.headline, | ||
| image: { | ||
| src: trail.masterImage ?? '', | ||
| altText: trail.linkText ?? '', | ||
| }, | ||
| isExternalLink: false, | ||
| onwardsSource: 'related-content', | ||
| showLivePlayable: false, | ||
| showQuotedHeadline: false, | ||
| url: trail.url, | ||
| webPublicationDate: trail.webPublicationDate, | ||
| isImmersive: false, | ||
| })); |
abeddow91
approved these changes
Jan 13, 2026
|
Seen on PROD (merged by @domlander 7 minutes and 18 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Implements the logic to show the gallery-style onwards content in all articles in the AB test.
I used an amalgamation of the previous AB test to implement gallery-style onwards content and the
MoreGalleries.tsxfile, which is the current way we render onwards content for gallery articles.The top onwards content container will show the updated design. The bottom onwards content container remains the same for the purposes of this AB test.
There aren't designs for this new style of onwards content: we have designs for this version of onwards content on gallery pages, but these cards look much different to standard cards. I've tried to make it look reasonable, but it would take an involved refactor of spacing within the Card component to how it handles onwards content to align everything perfectly, which I think is not worth doing until we have designs.
Why?
The WebX team recently migrated gallery articles to DCAR and whilst doing so implemented a new design for onwards content. An example can be seen in this gallery article
We would like to know whether using this type of design would lead to better user engagement (measured through click-through rate and session length) than the current design used on non-gallery articles.
Screenshots