Remove type and platform from logs
#15109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not using them for anything, and we're trying to reduce noise in the logs by removing fields we don't need. In addition, these fields duplicate information that's already in the path, which is also logged. For example, a request to `/AppsArticle` would have "apps" as the platform and "article" as the type. Furthermore, an extra function call is needed to log them whenever a new handler is created, whereas the path is logged automatically for every request. This may be why they're currently logged inconsistently, with both "app" and "apps" being used, and the platform sometimes not included, although some of this could also be solved by changing the types on `recordTypeAndPlatform`.
JamieB-gu
added
the
maintenance
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
arelra
approved these changes
Jan 12, 2026
DanielCliftonGuardian
approved these changes
Jan 12, 2026
|
Seen on PROD (merged by @JamieB-gu 8 minutes and 34 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not using them for anything, and we're trying to reduce noise in the logs by removing fields we don't need.
In addition, these fields duplicate information that's already in the path, which is also logged. For example, a request to
/AppsArticlewould have "apps" as the platform and "article" as the type. Furthermore, an extra function call is needed to log them whenever a new handler is created, whereas the path is logged automatically for every request. This may be why they're currently logged inconsistently, with both "app" and "apps" being used, and the platform sometimes not included, although some of this could also be solved by changing the types onrecordTypeAndPlatform.Part of #13136.